summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* gitlab: Only run CI in main and coverage branchesfirmware-ti50-prepvt-15086.B-mainfirmware-ti50-mp-15224.B-mainJeremy Bettis2022-09-121-0/+5
| | | | | | | | | | | | | | | | | | | | | | This workflow rule will prevent this CI config from running unless the branch name is "main" or "coverage". It will have to be cherry-picked into all the other branches to make them stop running sadly. BRANCH=None BUG=b:244766499 TEST=Used yaml validator at https://gitlab.com/zephyr-ec/ec/-/ci/editor?branch_name=main&tab=2 Signed-off-by: Jeremy Bettis <jbettis@google.com> Change-Id: I536de3e3fdbca1c48505e61de5737f865bd0e233 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3872545 Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Simon Glass <sjg@chromium.org> Auto-Submit: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Jeremy Bettis <jbettis@chromium.org> (cherry picked from commit 15612bc4af40cb2a824ff2590508df29f27fbf56) Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3891672
* TCPMv2: Adjust tPSSourceOn to proper valuestabilize-15086.B-mainScott Chao2022-09-011-1/+4
| | | | | | | | | | | | | | | | | | | | | According to USB Power Delivery Compliance Test Specification, Revision 1.4 Version 4(TEST.PD.PROT.SRC.10#3). UUT should send Type-C error recovery within tPSSourceOn. From the TEST.PD.PROT.SRC.10 test result, UUT sent Type-C Error Recovery after tPSSourceOn_Max(480ms).The time interval is 0.4896s which is exceeded the max timing(480ms). So I pick the value in the middle of 390ms and 480ms. BUG=b:242119728 BRANCH=none TEST=pass TEST.PD.PROT.SRC.10 Signed-off-by: Scott Chao <scott_chao@wistron.corp-partner.google.com> Change-Id: Icef77701eaadad71a204debe00f174d05eeceeae Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865416 Reviewed-by: Diana Z <dzigterman@chromium.org>
* zephyr: Fix PPC chips on the i2c nodes for herobrine variants.Adam Mills2022-09-015-24/+71
| | | | | | | | | | | | | | | | | Two of the herobrine variants (hoglin and villager) use different PPC chips to the other herobrine boards. To facilitate this difference between the boards, the variant specific i2c DTS files needed to be updated with the correct PPC chips. BUG=b:243759491 TEST=zmake build -a; ./twister -T zephyr/test/ BRANCH=main Signed-off-by: Adam Mills <adamjmills@google.com> Change-Id: I00748d71d458e847e141dbbfa3a1ffcf7fa63379 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864593 Reviewed-by: Wai-Hong Tam <waihong@google.com> Commit-Queue: Wai-Hong Tam <waihong@google.com>
* battery: print gauge C-FET statusEric Yilun Lin2022-09-011-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BUG=b:240883830 TEST=ec:~$ battery Status: 0x00e0 FULL DCHG INIT Param flags:00000002 Temp: 0x0bac = 298.8 K (25.7 C) V: 0x32e7 = 13031 mV V-desired: 0x0000 = 0 mV I: 0x0000 = 0 mA I-desired: 0x0000 = 0 mA Charging: Not Allowed Charge: 100 % Display: 100.0 % Manuf: COSMX Device: L22X3PG0 Chem: LiP Serial: 0x00bc V-design: 0x2c2e = 11310 mV Mode: 0x6020 Abs charge:100 % Remaining: 4152 mAh Cap-full: 4156 mAh Design: 4156 mAh Time-full: 0h:0 Empty: 0h:0 full_factor:0.97 shutdown_soc:4 % C-FET: 0 BRANCH=none Change-Id: Icbd8b357b608bf014f8670614fd3755a47b6d535 Signed-off-by: Eric Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855650 Tested-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com> Reviewed-by: Ting Shen <phoenixshen@chromium.org> Auto-Submit: Eric Yilun Lin <yllin@google.com>
* ps8xxx: Add caching to ps8xxx_get_chip_infoReka Norman2022-09-011-32/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During boot, depthcharge uses EC_CMD_PD_CHIP_INFO to check if the PS8XXX firmware needs to be updated. On nereid, this commands takes ~45 ms, which affects the AP boot time. Add caching to avoid reading registers on every call, specifically the fw_version register and the chip-specific registers used to disginguish between similar parts (e.g. reg_id for PS8815 vs PS8745). This is similar to the caching done by tcpci_get_chip_info(). On nereid, the EC_CMD_PD_CHIP_INFO time is reduced from ~45 ms to ~4 ms. Note, the reason the command is so slow is that reading the reg_id and fw_version registers causes a chip reset, so the chip is re-initialised in the middle of the host command (b:244386509). It's not clear whether this is expected. If this can be fixed, then we might choose to revert this, depending on how long the register reads take without the chip reset. BUG=b:242935354 BRANCH=None TEST=Check that `ectool pdchipinfo 1` still returns the correct info. Also add logging to check that cached info is used when live = 0, and not used when live = 1. Change-Id: I71dc0849270dbc729336e30d6264f7fea6898618 Signed-off-by: Reka Norman <rekanorman@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864596 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Commit-Queue: Reka Norman <rekanorman@chromium.org> Tested-by: Reka Norman <rekanorman@chromium.org>
* temp-sensor-rt9490: migrate to common thermistor codeTing Shen2022-09-017-75/+170
| | | | | | | | | | | | | | | | | | | Reuse existing linear interpolation algorithm and dts structure for rt9490 temperature calculation. BUG=none TEST=`temps` in ec console looks reasonable: ec:~$ temps ambient 324 K (= 51 C) charger 322 K (= 49 C) BRANCH=none Signed-off-by: Ting Shen <phoenixshen@google.com> Change-Id: If69d9332d81a5b23b851c76c2e0539d62cbdfe09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865584 Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Ting Shen <phoenixshen@chromium.org>
* zephyr: create common i2c dtsi filesDawid Niedzwiecki2022-09-018-938/+324
| | | | | | | | | | | | | | | For variants share a majority of the i2c nodes. Create an i2c dtsi file for these cases not to repeat code/configuration. BUG=b:228240586 TEST=zmake build -a BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: Ia4053c39e365e0d0924ac30e2633178f8ad79239 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858649 Reviewed-by: Keith Short <keithshort@chromium.org> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com>
* zephyr: add i2c dts files per board variantDawid Niedzwiecki2022-09-0123-126/+777
| | | | | | | | | | | | | | | | | | | | | | Some boards like krabby/tentacruel share the same i2c dts file, but not all i2c nodes are the same. It requires declaring the i2c nodes in other files like usbc.dts. Create an i2c file per board variant if the variants don't have the same i2c nodes. Also, move the remaining i2c nodes to the i2c files. BUG=b:228240586 TEST=zmake build -a BRANCH=main Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com> Change-Id: I10f77dcbff6b0116232358ccfd4d3a2cf9e2647f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858648 Reviewed-by: Adam Mills <adamjmills@google.com> Commit-Queue: Dawid Niedzwiecki <dawidn@google.com> Reviewed-by: Keith Short <keithshort@chromium.org>
* morthal: Initial EC imageYu-An Chen2022-09-018-0/+466
| | | | | | | | | | | | | | | | | | | | Create the initial Zephyr EC image for the morthal variant by copying the skyrim reference board EC files. More changes will be added later. BUG=none TEST=zmake build morthal BRANCH=none Signed-off-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Change-Id: I358b649c4674003c8531bcef4f7ea8727293141b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858969 Reviewed-by: Moises Garcia <moisesgarcia@google.com> Tested-by: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Auto-Submit: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Yu-An Chen <yu-an.chen@quanta.corp-partner.google.com>
* pujjo: enable BYPASS_CBI_EEPROM_WP and SYSTEM_UNLOCKED definearthur.lin2022-09-011-1/+5
| | | | | | | | | | | | | | | Add CONFIG_PLATFORM_EC_BYPASS_CBI_EEPROM_WP_CHECK Add CONFIG_PLATFORM_EC_SYSTEM_UNLOCKED BUG=b:244409551 BRANCH=none TEST=zmake build pujjo Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: I06f9b6d6f7a72beb8b04156098943bee9799211d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865216 Reviewed-by: Andrew McRae <amcrae@google.com> Reviewed-by: Peter Marheine <pmarheine@chromium.org>
* common: Not sleep 500ms when already left safe modeDavid Huang2022-09-012-15/+15
| | | | | | | | | | | | | | | | | Don not sleep 500ms when ec already left safe mode. BUG=b:226259582 BRANCH=main TEST=Check get battery info don't have 500ms delay in console. Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com> Change-Id: I740b49e654047800936086a9de33a87c7c46a300 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3853307 Commit-Queue: David Huang <david.huang@quanta.corp-partner.google.com> Tested-by: Daisuke Nojiri <dnojiri@chromium.org> Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* winterhold: Implement battery parameterLeila Lin2022-09-0111-4/+458
| | | | | | | | | | | | | | | | Setup battery parameter for winterhold BUG=b:242491702 BRANCH=none TEST=zmake build Signed-off-by: Leila Lin <leilacy_lin@compal.corp-partner.google.com> Change-Id: Ib236fc2d95ac0907ff0fd73194ede8f30083fa71 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861708 Tested-by: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com> Reviewed-by: Elthan Huang <elthan_huang@compal.corp-partner.google.com> Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: LeilaCY Lin <leilacy_lin@compal.corp-partner.google.com.test-google-a.com>
* usb_common: Move HPD Wake MKBP Source to TCPMv1/TCPMv2 common fileJameson Thies2022-09-012-9/+9
| | | | | | | | | | | | | | | | | | | | MKBP sources are declared using DECLARE_EVENT_SOURCE. For the EC_MKBP_EVENT_DP_ALT_MODE_ENTERED MKBP event, the source is only declared in usb_pd_policy.c, which is a TCPMv1 file. For boards using TCPMv2, the source is never declared causing mkbp_get_next_event in mkbp_event.c to return EC_RES_ERROR (0x2). This CL will move the EC_MKBP_EVENT_DP_ALT_MODE_ENTERED MKBP event source declaration to usb_common.c so that it exists in both TCPMv1 and TCPMv2. BUG=b:220875780 TEST=make try_builds_boards. make runhosttests. Triggered HPD wake event on a TCPMv2 device and received no "HC 0x0067 err 2" message. BRANCH=None Signed-off-by: Jameson Thies <jthies@google.com> Change-Id: Ib873b0b68fcf3bd1a191583d694bd6209d7205f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3866153 Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
* test: Add tests for lid_angle.c cover the basic code pathsYuval Peress2022-09-015-0/+80
| | | | | | | | | | | | | | Test the basic code paths of setting/getting the wake angle as well as having the lid at 45 while the wake angle is at either the min/max. BRANCH=none BUG=b:244402830 TEST=twister -T zephyr/test/drivers Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I076f00fe7f572ac3358a9471a51b6408ee082b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867250 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
* test: add tests for host command PD get/write log entryYuval Peress2022-09-014-0/+141
| | | | | | | | | | | | | | | | Verify that the boundary conditions are met for the PD get and write log entry commands as well as verify that the log entries are added to the log FIFO. BRANCH=none BUG=b:236075606 TEST=twister -s zephyr/test/drivers/driver.host_cmd Signed-off-by: Yuval Peress <peress@google.com> Change-Id: Ifb246ad6e964dac25d3f70868cb031d80585d99a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863942 Reviewed-by: Al Semjonovs <asemjonovs@google.com> Commit-Queue: Al Semjonovs <asemjonovs@google.com>
* util/flash_ec: Fix shellcheck warningTom Hughes2022-08-311-1/+1
| | | | | | | | | | | | | | | | | | "(${FILTERED_CHIPS[*]}). Use --chip= to choose one." ^------------------^ SC2154: FILTERED_CHIPS is referenced but not assigned. The FILTERED_CHIPS variable was removed in commit 1641ef6a6e12ca4e26764ad0a083fc07a08da96d. BRANCH=none BUG=b:242127759 TEST=./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I593431719a8a70e3e70d82be45b0461788d4c400 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864976 Reviewed-by: Namyoon Woo <namyoon@google.com>
* driver: st: Enable on/off body detection to lsm6dsmGwendal Grignou2022-08-315-18/+50
| | | | | | | | | | | | | | Remove simple macro in lsm6dso and move the code to report activities to common code. BUG=b:236799854 BRANCH=dedede TEST=Compile. Check on bugzzy the EC report on/off body detection. Change-Id: I7a1713182b4ee7807a2f681a70e664d0f4eae563 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860189 Reviewed-by: Diana Z <dzigterman@chromium.org>
* driver: bmi: Enable On/Off body detection on all BMI IMUGwendal Grignou2022-08-316-32/+36
| | | | | | | | | | | | | | Define a common function for setting the rms noise floor. Use static function per sensor to set the proper floor. BUG=b:236799854 BRANCH=dedede TEST=Compile Change-Id: I18e228fd98cb230a77d435f3865c8b249162a4bc Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860188 Reviewed-by: Diana Z <dzigterman@chromium.org>
* zephyr: test: Set start-up battery level to 50%Daisuke Nojiri2022-08-312-11/+6
| | | | | | | | | | | | | | | | This will avoid the flakiness of the virtual battery test (specifically test_read_regs) due to the power-on speed. BUG=b:243816417 BRANCH=None TEST=./twister -v -T zephyr/test Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: I10251fdd33acc184c3c0a86b93e646e326181829 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865907 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Al Semjonovs <asemjonovs@google.com>
* Agah: Remove UNUSED(PIN(7, 3))Daisuke Nojiri2022-08-311-1/+0
| | | | | | | | | | | | | GPIO73 is used for TA2. BUG=b:240286399 BRANCH=None TEST=buildall Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org> Change-Id: Iab25222c81061c87802a3193c14f7d948bd3931b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867531 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
* test: Add tests for panic info host commandYuval Peress2022-08-312-0/+99
| | | | | | | | | | | | | | | Add tests for the panic info host command including error paths for bad magic number and panic data size 0. BRANCH=none BUG=b:236074360 TEST=twister -s zephyr/test/drivers/drivers.host_cmd Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I9773afab20e3236faa32bd50915e5fb505036cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863929 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
* test: Add tests for panic_data getterYuval Peress2022-08-311-0/+16
| | | | | | | | | | | | | | | Verify the logic around the panic data pointer getter when the magic number is changed. BRANCH=none BUG=b:236074360 TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I06be7a53302f6cd391f1eb757ed8f46dde043497 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863928 Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: add missing includes to various test filesYuval Peress2022-08-313-1/+4
| | | | | | | | | | | | | | A few headers were missing and causing warnings BRANCH=none BUG=none TEST=twister -T zephyr/test/drivers Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I98f6a13be6a8e70cfb30c69b70a9c7839eb9b0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863927 Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* docs/reducing_ec_image_size: Update commands used by FAFT/TASTRobert Zieba2022-08-311-4/+4
| | | | | | | | | | | | | | | | This commit updates the documentation for CONFIG_CMD_PD, CONFIG_CMD_KEYBOARD, CONFIG_CMD_CRASH, and CONFIG_CMD_FLASHINFO to reflect the FAFT/TAST that use these commands. BRANCH=none BUG=none TEST=none Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: I72e295695800615ff2a6c903ccbfb29e5945c766 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867791 Reviewed-by: Diana Z <dzigterman@chromium.org> Commit-Queue: Diana Z <dzigterman@chromium.org>
* skyrim: re-enable `pd` console commandRobert Zieba2022-08-311-1/+0
| | | | | | | | | | | | | | | This commit re-enables the `pd` console command which is used by `firmware.ECSystemLocked`. BRANCH=none BUG=b:209512212 TEST=Ran `firmware.ECSystemLocked` on skyrim Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: Iccae231b114f025f56a6c52b760a1432718ba45d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867790 Reviewed-by: Rob Barnes <robbarnes@google.com> Commit-Queue: Rob Barnes <robbarnes@google.com>
* skyrim: re-enable keyboard commandsRobert Zieba2022-08-311-1/+0
| | | | | | | | | | | | | | | This commit re-enables various keyboard console commands. These are used by `firmware_ECKeyboard` among various others. BRANCH=none BUG=b:209512212 TEST=Ran `firmware_ECKeyboard` on skyrim Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: Id484528126110958b27455f6317bb4b30ea4e8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867789 Reviewed-by: Rob Barnes <robbarnes@google.com> Commit-Queue: Rob Barnes <robbarnes@google.com>
* skyrim: re-enable `flashinfo` commandRobert Zieba2022-08-311-1/+0
| | | | | | | | | | | | | | | | This commit re-enables the `flashinfo` command which is required by the TAST test `firmware.ECSize`. BRANCH=none BUG=b:209512212 TEST=Ran `firmware.ECSize` on skyrim Signed-off-by: Robert Zieba <robertzieba@google.com> Change-Id: I1fc86dffbc3fed6bd4ac661729e43a9c24009aca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3867788 Commit-Queue: Rob Barnes <robbarnes@google.com> Reviewed-by: Rob Barnes <robbarnes@google.com> Reviewed-by: Diana Z <dzigterman@chromium.org>
* test: add tests for crash console commandYuval Peress2022-08-315-0/+39
| | | | | | | | | | | | | | | | | Adds basic tests for the crash console command involving ASSERT() crashes. This change enables the ASSERT_TEST config and creates a new assert handler using FFF. We then can use that mock to verify that the assert was called. BRANCH=none BUG=b:236074360 TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I59c24bc4ed4ef81dde5cce16ac0ae4ef96f124cc Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863125 Reviewed-by: Wai-Hong Tam <waihong@google.com> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: Add basic tests exercising the panic output APIYuval Peress2022-08-3111-12/+121
| | | | | | | | | | | | | | | | | Exercise some of the panic output API. Some of the basic printing API cannot yet be fully tested. But a fix upstream is coming to allow us to use the 'console' harness features to parse the output log and pass/fail the test based on output. BRANCH=none BUG=none TEST=twister -s zephyr/test/drivers/drivers.default Signed-off-by: Yuval Peress <peress@google.com> Change-Id: I8e56e8bcdaa0e095891c38a26e56ced8f3a8d4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3855593 Reviewed-by: Simon Glass <sjg@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* pujjo: define KEYBOARD_REFRESH_ROW3arthur.lin2022-08-311-0/+1
| | | | | | | | | | | | | | | | Pujjo's reflash key is on KSI3. Define CONFIG_PLATFORM_EC_KEYBOARD_REFRESH_ROW3 to fix issue for press "esc + refresh + power button" can't enter recovery screen. BUG=b:243728711 BRANCH=none TEST=zmake build pujjo TEST=press "esc + refresh + power button" and it can show recovery screen Signed-off-by: arthur.lin <arthur.lin@lcfc.corp-partner.google.com> Change-Id: If7c571945dc4f689ebb69eb9738282069d2928fd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3865128 Reviewed-by: Andrew McRae <amcrae@google.com>
* Craask: add 2nd source for BASE sensorSue Chen2022-08-315-1/+92
| | | | | | | | | | | | | | | Use SSFC bit 4-5 to identify BASE SENEOR 0: lsm6dso 1: bmi323 BUG=b:240040384 BRANCH=none TEST=can read raw data from bmi323 after setting ssfc=0x10 Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ie9109cd8a13e782718b3abeb931c6b707804794c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3823545 Reviewed-by: Andrew McRae <amcrae@google.com>
* nissa: xivu: add customized xivu/cbi.dtsShou-Chieh Hsu2022-08-312-0/+78
| | | | | | | | | | | | | | | | FW_CONFIG bit 0 and bit 1 is already occupied in Xivu in boxster config. So we want to overwrite the EC FW_CONFIG definition for Xivu. BUG=b:244121371 TEST=zmake build xivu `ectool cbi set 6 0x7 4` and check typeC sub-board functionality BRANCH=None Signed-off-by: Shou-Chieh Hsu <shouchieh@chromium.org> Change-Id: Iac54979f7d44de376e7a0ff305d5cf447f34edde Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864608 Reviewed-by: Henry Sun <henrysun@google.com> Tested-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
* Xivu: Implement correct LED behaviorjohnwc_yeh2022-08-312-221/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement LED behavior. Power LED: Discharge in S0 : White on Discharge in S3 : Blinking White, 1sec on /3sec off Discharge in S5 : Off Charge LED: Charge : Amber on Full charge : White on Battery Low(0~10%) in S0 : Blinking Amber, 1sec on /3sec off Battery Low(0~10%) in S3 : Blinking White, 1sec on /3sec off Battery Low(0~10%) in S5 : Off Battery Error in S0 : Blinking Amber, 1sec on /1sec off Battery Error in S3 : Blinking White, 1sec on /3sec off Battery Error in S5 : Off BUG=b:237224850 BRANCH=none TEST=zmake build xivu Signed-off-by: johnwc_yeh <johnwc_yeh@compal.corp-partner.google.com> Change-Id: I759127464006f60507479185a9ac4c8fe30ae5bf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3833265 Reviewed-by: Peter Marheine <pmarheine@chromium.org> Tested-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com> Reviewed-by: SamSP Liu <samsp_liu2@compal.corp-partner.google.com>
* zephyr: test: Add the flash info host command testWai-Hong Tam2022-08-301-0/+28
| | | | | | | | | | | | | | | Add the test for the flash info host command. BRANCH=None BUG=b:236075281 TEST=./twister -s zephyr/test/drivers/drivers.default Change-Id: I6534ae8fffda0b895e541f97ef1be0c5b11b865a Signed-off-by: Wai-Hong Tam <waihong@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3866424 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Yuval Peress <peress@google.com> Reviewed-by: Yuval Peress <peress@google.com>
* docs/ide-support.md: Add Makefile.ide to odd file typesAndrea Grandi2022-08-301-0/+1
| | | | | | | | | | | | BUG=b:236389226,b:176500425 TEST=none BRANCH=none Signed-off-by: Andrea Grandi <agrandi@google.com> Change-Id: Id299114099cb0e26c26de547287ee90618294ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861290 Reviewed-by: Bobby Casey <bobbycasey@google.com> Reviewed-by: Craig Hesling <hesling@chromium.org>
* Prism: Remove const keyword from rgbkbd_type variableParth Malkan2022-08-302-2/+2
| | | | | | | | | | | | | | Rgbkbd_type could be set at runtime, remove const. BUG=b:242259557 BRANCH=none TEST=None Cq-Depend: chromium:3864981, chromium:3861817, chromium:3866411 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I92bd1e326d20b272afe5bede850f6bb090e86c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864982 Reviewed-by: YH Lin <yueherngl@chromium.org>
* Osiris: Remove const keyword from rgbkbd_type variableParth Malkan2022-08-301-1/+1
| | | | | | | | | | | | | | Rgbkbd_type could be set at runtime, remove const. BUG=b:242259557 BRANCH=none TEST=None Cq-Depend: chromium:3864982, chromium:3861817, chromium:3866411 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: I63e7f034aeb3ca31cbe293e5d2c4defd8c21176e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3864981 Reviewed-by: YH Lin <yueherngl@chromium.org>
* Mithrax : Modify RGBKBD config for non-gaming SKU.Logan_Liao2022-08-303-6/+9
| | | | | | | | | | | | | | | | | | | | This patch modify RGB_type setting to distinguish gaming and non-gaming SKU. BUG=b:242259557 BRANCH=none TEST=test Mithrax without RGB keyboard that return EC_RGBKBD_TYPE_UNKNOWN. Cq-Depend: chromium:3864981, chromium:3864982, chromium:3866411 Change-Id: I3f6485319d36b2ef619d597ea75dc074838b7562 Signed-off-by: Logan_Liao <logan_Liao@compal.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861817 Reviewed-by: Logan Liao <logan_liao@compal.corp-partner.google.com> Reviewed-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Parth Malkan <parthmalkan@google.com> Commit-Queue: Parth Malkan <parthmalkan@google.com> Tested-by: Parth Malkan <parthmalkan@google.com> Reviewed-by: Ko Ko <ko_ko@compal.corp-partner.google.com>
* taniks: Remove const keyword from rgbkbd_type variableParth Malkan2022-08-301-1/+1
| | | | | | | | | | | | | | Rgbkbd_type could be set at runtime, remove const. BUG=b:242259557 BRANCH=none TEST=None Cq-Depend: chromium:3864982, chromium:3861817, chromium:3864981 Signed-off-by: Parth Malkan <parthmalkan@google.com> Change-Id: Ie0088fabe6837608c10315c58ad40643c12b7627 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3866411 Reviewed-by: YH Lin <yueherngl@chromium.org>
* util/flash_ec: Fix shellcheck warningsTom Hughes2022-08-301-11/+11
| | | | | | | | | | | | | | | | | | ${STM32MON_COMMAND} "${IMG}" \ ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. Convert the variable to an array to split on spaces correctly: https://github.com/koalaman/shellcheck/wiki/Sc2086#exceptions. BRANCH=none BUG=b:242127759 TEST= ./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ia5c277cf090aa773b58403cef8a99c5cf974804d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858400 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* util/flash_ec: Fix shellcheck warningsTom Hughes2022-08-301-10/+10
| | | | | | | | | | | | | | | dev_cnt=$(lsusb -d ${DFU_DEVICE} | wc -l) ^-----------^ SC2248: Prefer double quoting even when variables don't contain special characters. BRANCH=none BUG=b:242127759 TEST=./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: Ie299348fc4aa94db2c6060c38c27fadb52525389 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860075 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* util/flash_ec: Fix shellcheck warningsTom Hughes2022-08-301-35/+35
| | | | | | | | | | | | | | | | SCRIPT_DIR="$(dirname "$SCRIPT")" ^-----^ SC2250: Prefer putting braces around variable references even when not strictly required. BRANCH=none BUG=b:242127759 TEST=./util/flash_ec --board=dartmonkey Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I95384821f047bb0599997be64843b90d55c297bd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3860074 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* rex: Fix the gpio pin type for ec_edp_bl_enScott Collyer2022-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | The gpio device tree node for ec_edp_bl_en was being configured as an open-drain signal, but this should be a TTL with low as its initial state. This CL corrects this error. The GPIO spreadsheet that's being used as an input for pinmap needs to be updated. This CL provides a fix to enable the display panel to work until the tool that creates the input for pinmap is updated. BRANCH=none BUG=b:243919230 TEST=zmake build rex Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I4f8db1e150572df58c1a97d1f509a556383eb0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863925 Reviewed-by: Madhu P <mparuchuri@google.com> Reviewed-by: Subrata Banik <subratabanik@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Tested-by: Scott Collyer <scollyer@chromium.org>
* brya: Set fan PWM frequency to 25 KHzCaveh Jalali2022-08-301-2/+2
| | | | | | | | | | | | | | | | The brya fan spec calls for the PWM frequency to be 25 KHz. Many brya variants already use 25 KHz as this is a common PWM frequency for fans. BRANCH=none BUG=none TEST=changed fan speed with "fanduty" and confirmed resulting speed with "faninfo" and physically. Change-Id: I26d5d7fa044f1de6a7c1781abe2eadc20e72a413 Signed-off-by: Caveh Jalali <caveh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3833561 Reviewed-by: Boris Mittelberg <bmbm@google.com> Commit-Queue: Boris Mittelberg <bmbm@google.com>
* zephyr: Add `pe` and `pdcable` console command testsAl Semjonovs2022-08-301-0/+80
| | | | | | | | | | | | | | Added tests for `pe` and `pdcable` console commands BUG=b:236074967, b:236074968 BRANCH=NONE TEST=./twister -T zephyr/test Signed-off-by: Al Semjonovs <asemjonovs@google.com> Change-Id: Ie7e7ea367b12f7fc3eaa47fae9c04861ad902af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863127 Reviewed-by: Abe Levkoy <alevkoy@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
* test: Add test for get_ikm succeedFiras Sammoura2022-08-301-0/+33
| | | | | | | | | | | | | | | Add test for get_ikm succeeds when the tmp seed is set and the rollback can successfully get the secret. BRANCH=None BUG=b:242720240 TEST=make run-fpsensor_crypto TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: I14d0887aa2ecafe4565141a89ad5fb43317cc1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3863124 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for get ikm failure with when secret failFiras Sammoura2022-08-301-0/+23
| | | | | | | | | | | | | | | Add a test for get_ikm when the tmp seed is set and the rollback_get_secret is failing. BRANCH=None BUG=b:242720240 TEST=make run-fpsensor_crypto TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: Ida1f40943eb5fa7795a658a1c8a318036f164d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3861202 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for get ikm failure when seed not setFiras Sammoura2022-08-302-2/+13
| | | | | | | | | | | | | | | | | | Add a test for get_ikm when the fp tpm seed is not set. Change the declaration of get_ikm function inside fpsensor_crypto.c to test_export_static such that it can be visible in the test library. Declare get_ikm as an extern function inside the test/fpsensor_crypto.c file. BRANCH=None BUG=b:242720240 TEST=make run-fpsensor_crypto TEST=make runhosttests Signed-off-by: Firas Sammoura <fsammoura@google.com> Change-Id: Ibd4993bbeb6e8d166b3d0307fd1b3c90c55cc264 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3862148 Reviewed-by: Bobby Casey <bobbycasey@google.com>
* test: Add test for fpsensor trivial key failureBobby Casey2022-08-306-2/+188
| | | | | | | | | | | | | | | | | | | Add a test for derive_positive_match_secret when compute_hmac_sha256 returns a trivial key (either 0x00 or 0xFF). This required mocking compute_hmac_sha256 to get the proper test behavior. Since other tests depend upon a proper SHA256 hash to be generated, either all key/message combinations would need to be mocked or some calls to compute_hmac_sha256 need to be passed through to hmac_SHA256. The latter option was chosen for the best flexibility moving forward. BRANCH=none BUG=b:242720910 TEST=make runhosttests Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: I959e23cfadb5460e62af90ffba74a0cd3b9d9a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3838935 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
* fpsensor_crypto: Abstract calls to hmac_SHA256Bobby Casey2022-08-301-4/+10
| | | | | | | | | | | | | | | For testing purposes it is desirable to have a single location where all calls to hmac_SHA256 are called. Doing so makes mocking or replacing calls much easier. BRANCH=none BUG=b:242720910 TEST=make run-fpsensor_crypto Signed-off-by: Bobby Casey <bobbycasey@google.com> Change-Id: Icc158b3e895da11d072c65a19a36f3e1b29bca14 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3838934 Reviewed-by: Tom Hughes <tomhughes@chromium.org>
View Lorry Controller Status