| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Change-Id: I0f03f432ada1064ffba9595be78ca7ab4d25ecd1
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3155062
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Owners-Override: Jora Jacobi <jora@google.com>
Tested-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- command 'calibrate' added for accel/gyro calibration
- command 'offset' modified so that it can also set offset manually
BUG=b:159557101
BRANCH=none
TEST=build ectool and run following commands.
'ectool motionsense calibrate 2'
'ectool motionsense offset 2 -- -187 312 -62'
Change-Id: I58d0920e0ed48145cad55587ee3ba125d6a5c175
Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2256964
Reviewed-by: Jett Rink <jettrink@chromium.org>
(cherry picked from commit 40d09f45d976574338455821a01faae79174a7c2)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2280863
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nightfury uses opt3001 for base ALS sensor.
So we need to update board files for nightfury.
BUG=b:149226871
BRANCH=firmware-hatch-12672.B
TEST=emerge-hatch chromeos-ec
flash ec and check ectool motionsense
Signed-off-by: Jongpil Jung <jongpil19.jung@samsung.corp-partner.google.com>
Change-Id: I86ee37140d1a74d85baec53e0dd8792bd6b77362
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2100563
Reviewed-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
(cherry picked from commit 26900d2e8c76f9b04d560def5aa459fd42742341)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120754
Tested-by: Bob Moragues <moragues@chromium.org>
(cherry picked from commit 7821038e234786255a6316424bf0f6e7fccdf29d)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128896
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of 992eb796134c0f9d76ad4fab092bc5647d36b22c
Original change's description:
> nightfury: enable lid accelerometer lis2ds12
>
> BUG=b:149226871
> BRANCH=none
> TEST=make -j BOARD=nightfury
> flash ec and run 'ectool motionsense'
>
> Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
> Change-Id: I698f8990b3da0970273da59ca95fd4d363723a1a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2123622
> Reviewed-by: Bob Moragues <moragues@chromium.org>
> Reviewed-by: Scott Collyer <scollyer@chromium.org>
> Tested-by: Bob Moragues <moragues@chromium.org>
> Commit-Queue: Bob Moragues <moragues@chromium.org>
> (cherry picked from commit e3c9d2ab77571008734279986aa9a12b1450e5ab)
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124435
Bug: b:149226871
Change-Id: I2b087ae1590b17374082db0daa0d092cee1fdce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128691
Reviewed-by: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added ACC LIS2DS/LIS2DS12 driver support.
Features included:
- FIFO support with watermark interrupt events
- Uses shared function with other ST MEMs devices
BUG=none
BRANCH=master
TEST=Tested on discovery_stmems target BOARD with LIS2DS
connected to EC i2c master bus and motion sense task running.
All basic features tested including changing in ODR and Full
Scale Range. Also tested FIFO features and interrupt management.
Change-Id: I8a9e96f59ebdca7e622cff29676c5e1a9e0d58f5
Signed-off-by: Mario Tesi <mario.tesi@st.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/481480
Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
(cherry picked from commit 21b0abea499c4b7d9638c86f1e8284711493f6a5)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124434
Reviewed-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
Reviewed-by: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BC1.2 IC of nightfury is Pericom 9201.
BUG=b:147798205
BRANCH=firmware-hatch-12672.B
TEST=make -j BOARD=nightfury
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I0eaf4d3c9f09d005acafd5827d93b3367bc1db36
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2111913
Tested-by: Jongpil Jung <jongpil19.jung@samsung.corp-partner.google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
(cherry picked from commit 11b0f59e33b4683225232c1ee809e78a89cd782c)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120873
Tested-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
(cherry picked from commit 494ef7dde578bc40f2c97be79c26b3701fcafa25)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128904
Reviewed-by: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 992eb796134c0f9d76ad4fab092bc5647d36b22c.
Reason for revert: Bad Cherry Pick
Original change's description:
> nightfury: enable lid accelerometer lis2ds12
>
> BUG=b:149226871
> BRANCH=none
> TEST=make -j BOARD=nightfury
> flash ec and run 'ectool motionsense'
>
> Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
> Change-Id: I698f8990b3da0970273da59ca95fd4d363723a1a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2123622
> Reviewed-by: Bob Moragues <moragues@chromium.org>
> Reviewed-by: Scott Collyer <scollyer@chromium.org>
> Tested-by: Bob Moragues <moragues@chromium.org>
> Commit-Queue: Bob Moragues <moragues@chromium.org>
> (cherry picked from commit e3c9d2ab77571008734279986aa9a12b1450e5ab)
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124435
Bug: b:149226871
Change-Id: I28a40e8b6c26956976e0ea647f45631927f35920
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128902
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
Auto-Submit: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:149226871
BRANCH=none
TEST=make -j BOARD=nightfury
flash ec and run 'ectool motionsense'
Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
Change-Id: I698f8990b3da0970273da59ca95fd4d363723a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2123622
Reviewed-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
(cherry picked from commit e3c9d2ab77571008734279986aa9a12b1450e5ab)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124435
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To fix build error, we need to remove unused devices code for nightfury.
Moreover, nightfury doesn't have components.
So, remove items
RGB Sensor and WF camera SYNC
BUG=b:149226871
BRANCH=firmware-hatch-12672.B
TEST=emerge-hatch chromeos-ec
Change-Id: Ie0b77f3825c0433ac1c70aed90c33f394c2f59ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2115893
Tested-by: Jongpil Jung <jongpil19.jung@samsung.corp-partner.google.com>
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The starting point for the nightfury EC image.
BUG=b:149226871
BRANCH=firmware-hatch-12672.B
TEST=make -j BOARD=nightfury
Change-Id: Ifafb645737b3e7c1aa9245a359e3df47ca9d66fa
Signed-off-by: Raymond Chung <raymondchung@ami.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2050103
Commit-Queue: Philip Chen <philipchen@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
(cherry picked from commit fdf16228202ced2220d8b511d14798ccc8a93bfb)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2113932
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, stm32mon will try to get the attention of the
stm32 bootloader for forever ("Starting monitor").
Retrying forever is odd behavior, in general.
Furthermore, this behavior does not allow wrapper scripts to
observe the failure and try other retry mechanisms, like
resetting the chip.
TL;DR
This CL sets a default 40 retries for the bootloader connect/sync
and adds the "--retries <num-retries>" and "-R <num-retries>" argument
for adjustments.
Note, this is simply the retry limit for connecting/syncing-with the
bootlodaer.
You can specify "-R -1" to try forever.
BRANCH=nocturne,hatch
BUG=b:143374692,b:144729003
TEST=cros_workon --board=nocturne start chromeos-base/ec-devutils
emerge-nocturne chromeos-base/ec-devutils
cros deploy --root=/usr/local dut1 chromeos-base/ec-devutils
# Bind spidev for fpmcu
# Enable hardware wp
time stm32mon -U -u -p -s /dev/spidev32765.0 -e -w \
/opt/google/biod/fw/nocturne_fp_v2.2.110-b936c0a3c.bin
# Check that it tries forever??
time stm32mon -R 10 -U -u -p -s /dev/spidev32765.0 -e -w \
/opt/google/biod/fw/nocturne_fp_v2.2.110-b936c0a3c.bin
# Check that is only makes 11 attempts
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I925466fb892b0d17a7ff8b354e3cee302d167d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1913332
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
(cherry picked from commit 5908893e03d878d4b3486449bb8adc2a1e8ae19b)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2091135
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This small 100ms sleep is necessary to stabilize the spidev driver.
Without it, we have seen that stm32mon is unable to catch
the stm32h743 bootloader on the first attempt.
This issue became more noticeable with the STM32H743 Rev V.
Among other things, the following log shows test results from before
adding this sleep and the flash_fp_mcu stress test results after
adding this sleep:
https://drive.google.com/open?id=1opJn5fPXxUMjMZz0VDtmqpCXN0mVnBr5
BRANCH=nocturne,hatch
BUG=b:143374692,b:144729003,b:135033816
TEST=# Ensure PS crrev.com/c/1921705 is applied.
# Run http://go/bit/hesling/5791510394044416
TEST=See the testing done in the above Google Drive log.
Change-Id: I1777c894e1dd8911df4d407e33dc677373146eb1
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1925174
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
(cherry picked from commit b80e142133ed2ea5ff5e604c9fedbaa520f22a45)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047628
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a "hello" mode to flash_fp_mcu that bypasses file operations.
The function is to only say hello to the bootloader, in order to
conduct stress tests with flash_fp_mcu.
BRANCH=nocturne,hatch
BUG=b:143374692,b:144729003
TEST=# Ensure PS crrev.com/c/1921705 is applied.
# Run http://go/bit/hesling/5791510394044416
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Iadcc52f11f8186dfea35445ce5ffbb6fb40d7a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1921705
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Tested-by: Tom Hughes <tomhughes@chromium.org>
(cherry picked from commit 0fffe36e799cd7d0d0ecc7f28d01c332cdcebd57)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047627
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does not change the behavior of flash_fp_mcu.
It simply removes two unnecessary variables and simplifies the flag
building logic.
BRANCH=nocturne,hatch
BUG=b:143374692,b:144729003
TEST=# Nocturne
flash_fp_mcu /opt/google/biod/fw/*.bin
TEST=# Ensure PS crrev.com/c/1921705 is applied.
# Run http://go/bit/hesling/5791510394044416
Change-Id: Icf96d837ed1c8a00e881fb79b42b8f8ccd893ca5
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2036602
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Tested-by: Tom Hughes <tomhughes@chromium.org>
(cherry picked from commit 9bf11ed2f7761f8a826782c09f7ad8d1a1531c80)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047626
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does not change the default behavior of flash_fp_mcu.
It does, however, allow the number of retries to be overridden using
env variables.
BRANCH=nocturne,hatch
BUG=b:143374692,b:144729003
TEST=# Nocturne
flash_fp_mcu /opt/google/biod/fw/*.bin
TEST=# Ensure PS crrev.com/c/1921705 is applied.
# Run http://go/bit/hesling/5791510394044416
Change-Id: Ieba0cec022f3463b529655ecc204753db7404f7d
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2036601
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Tested-by: Tom Hughes <tomhughes@chromium.org>
(cherry picked from commit d80fac9814428aa69e24e9553f0f3815745f8f38)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047625
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds reset and retry logic.
This is important because stm32mon sometimes fails to get the stm32
bootloader's attention on startup, so we need to reset the chip and
try again.
BRANCH=nocturne,hatch
BUG=b:143374692,b:144729003
TEST=# Nocturne
flash_fp_mcu /opt/google/biod/fw/*.bin
TEST=# Ensure PS crrev.com/c/1921705 is applied.
# Run http://go/bit/hesling/5791510394044416
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I755d9b8cbb8813fe961f359c128c674e4c395ebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1913626
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
(cherry picked from commit 80c42a77f0e8f2f553b969e1ef20436495228f08)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2047624
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the read temperature function to the driver when an FPU
is available.
BUG=b:138303429,chromium:1023858
TEST=None
BRANCH=None
Change-Id: I29e596af202def07c296fa1b478c711d31517999
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1859454
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
(cherry picked from commit 61203550b8421ec5d539e275b9f2fefc26f9d929)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2013648
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a feature flag for online calibration.
BUG=b:138303429,chromium:1023858
BRANCH=None
TEST=buildall since flag is not yet used
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: I3036371a7499bf0eaf0846ff07eec6e6ee18a391
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834021
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Yuval Peress <peress@chromium.org>
Tested-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1979585
Tested-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org>
(cherry picked from commit e4b0cfefb5239da458efea5de50154a74ff74b6f)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2008969
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 267da3cfc increased the response size of the motionsense "info"
command implicitly by adding a new version of the command. ectool
explicitly gets the latest version of the command to use, and the kernel
was complaining because it only requested 16 bytes, but the new version
sends back 19. Hence, update the expected size of the response to
compensate for this.
BUG=b:147472780, b:147720232
BRANCH=firmware-hatch-12672.B
TEST=ectool motionsense info X now returns data instead of failing
Change-Id: Ib297c02f55406b4dc3b8bb0b6b0843165b350995
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2007897
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Evan Green <evgreen@chromium.org>
(cherry picked from commit c520344abe270967b1bd96d43559fb00c0d431d4)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2009524
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If Cr50 is running older than 0.3.20, delay the RO update 1 minute after
the RW update, so Cr50 doesn't reject the RO blocks because their
offsets are less than the RW offsets.
BUG=b:144873413
BRANCH=none
TEST=update board running RO 0.0.10 RW 0.3.18 to the RO 0.0.11 RW 0.3.22
image.
Change-Id: I0179cc235c692133b08cd3430d71069b2f94bf69
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1929481
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
(cherry picked from commit 1503fa64670763133409d7b3fd59a91a7a28171d)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1989584
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The starting point for the stryke EC image
(Auto-Generated by create_initial_ec_image.sh version 1.0.0).
BUG=b/145101696
BRANCH=none
TEST=make BOARD=stryke
Change-Id: Id4546da9d79d6692cd66dc6b44f46973e8c50e58
Signed-off-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1935472
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Commit-Queue: Shelley Chen <shchen@chromium.org>
(cherry picked from commit fb13bbb87233de2a1b55e76f86eae974f6ff0a32)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1950268
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix build issue, replaced motion_sense_fifo_add_data with
motion_sense_fifo_stage_data and motion_sense_fifo_commit_data
fifo api.
BUG=none
BRANCH=master
TEST=Fixed build issue. Tested on discovery target BOARD with
LSM6DSO connected to EC i2c master bus and motion sense task
running.
Change-Id: I7e4e81f1b6fe95b33ef6a4bfc5fdd509273c6f7b
Signed-off-by: Mario Tesi <mario.tesi@st.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1903129
Reviewed-by: Yuval Peress <peress@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some servo micros will fail to jump to RW if we leave the USART hardware
modules active during the RW jump and the RW jump tries to change the
gpio flags to anything other than alternate in gpio.inc.
We would like the state transition from RO to RW to be as clean as
possible, so shutdown the hardware modules that RW will reinitialize in
board_init right after the jump
BRANCH=servo
BUG=b:144356961
TEST=flash this image on a bad servo micro, the remove then change
GPIO_ALTERNATE to GPIO_INPUT and reflash and see that it sauce's fully
flashes from then on
Change-Id: I81fcbbcda9f63761a719f6e0cb6bb4cf6962f18f
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1922240
Tested-by: Brian Nemec <bnemec@chromium.org>
Reviewed-by: Brian Nemec <bnemec@chromium.org>
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added IT8801 io expander (which includes keyboard controller) and
the keyscan task.
BUG=b:133200075
TEST="it8801_dump" should check presence of the IT8801 chip
TEST="ksstate on", press keys, see keyboard log things being printed on console
BRANCH=master
Change-Id: I08e7312cec59b6d293c01daf40b2f784a10b7e72
Signed-off-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1693863
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IT8801 is an I/O expander with a keyboard matrix controller.
BUG=b:133200075
BRANCH=none
TEST=Press any key on keyboard and the console command
"ksstate on" can print keyboard scan state.
Change-Id: I6903aad1eacfdfb6a7c6c04e6954a14e8c8caaac
Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com>
Signed-off-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1677976
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the addition of external i2c keyboard controllers, chips that don't
necessarly have gpios going to a keyboard can now still have a TASK_KEYSCAN.
Therefore it's wrong to assume we want the chip/*/keyboard_raw code included.
There was no easy way to make an ways on option (eg: CONFIG_KEYBOARD_RAW)
that could get #undefd in strategic places. The place that would always
define it would be in include/config.h but I don't believe that executes
before the build.mk rules.
BUG=b:135895590
TEST=Other boards with keyboards still happy.
TEST=No compile errors (regarding missing keyboard GPIOS) when declaring
TASK_KEYSCAN on a fresh stm32 board.
BRANCH=master
Change-Id: I061812a6941a11784950280648912edd5844bd79
Signed-off-by: Alexandru M Stan <amstan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1693862
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There should be no functional difference to fpcapture or fpenroll,
since the restricted console command feature is implemented in a
similar manor.
The only noticeable difference is that the list of commands provided
by the "help" command should denote when these commands are restricted.
Note, each board requires a configuration, similar
to crrev.com/c/1867388, in order to activate restricted
console commands. Otherwise, this restricted flag has no
restricting effect.
BRANCH=nocturne
BRANCH=hatch
BUG=b:142559996, b:142505927
TEST=# Test on nocturne_fp
make BOARD=nocturne_fp
scp build/nocturne_fp/ec.bin dut1:~/
ssh dut1 flash_fp_mcu ./ec.bin
# From FPMCU UART console
version
# Ensure that version is custom based on workstation
help
# Ensure that fpcapture and fpenroll are not prefixed
# with "-"
help list
# Ensure that a "Flags" column exists and that
# fpcapture and fpenroll both have a 1 in the column.
fpcapture
fpenroll
# Ensure that both commands above succeed in their
# own operations
syslock
fpcapture
fpenroll
# Ensure that both commands above fail with "Access Denied"
help
# Ensure that fpcapture and fpenroll are now prefixed
# with "-" in the help message
Change-Id: Icbb74a1afece66db9ebd071de0770650d42bd553
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1869400
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=none
Change-Id: I2c0b404ddfbd8e35fcc7455d93c1830167baa564
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1922229
Reviewed-by: Craig Hesling <hesling@chromium.org>
Commit-Queue: Craig Hesling <hesling@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BRANCH=none
BUG=none
TEST=none
Change-Id: I9305add05965579e5cc4ffed54704a17da27e275
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1922228
Reviewed-by: Craig Hesling <hesling@chromium.org>
Commit-Queue: Craig Hesling <hesling@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:143188569
TEST=make buildall still succeeds
BRANCH=none
Change-Id: I9193878c65b20293fad5914af88ea4e49be369a8
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1913939
Reviewed-by: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change battery discharging max temperature from 60 to 70.
BUG=b:143910072
BRANCH=master
TEST=flash EC and check battery charging.
Change-Id: Ia5a6a7c565e96e880715c6a03727c51a70dcab7c
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1806175
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When driver's setting pd message header function is called
from TCPM, driver shouldn't set cc resistance. We should
follow the comment just setting header defined in set_msg_header.
The message header power role equal our cc resistance Rp/Rd
state in mostly case. But there is an exception, like
power role swap from SNK to SRC, there is a temporal transition
state that both port cc assert Rd and GoodCRC power role field
is swapped for response original SRC PS_RDY, so we shouldn't
assert cc in set_msg_header function.
[refer]: PD3.0 spec v2 ch8.3.2.6
BUG=none
BRANCH=none
TEST=connect to dongle, adapter, DRP on board ampton
1.Power role swap successfully
2.PD state to SRC_RDY or SNK_RDY
Change-Id: Ibad3d8fcfcaa382fef4c8ef8ed26e920c63730b5
Signed-off-by: Ruibin Chang <Ruibin.Chang@ite.com.tw>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1916759
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets up the driver (mostly copied from cometlake for now), to be
used by puff.
BUG=b:143188569
TEST=make buildall still succeeds
BRANCH=none
Change-Id: I4a4b70dd8ba58c070e2c6ad5941911bab16bafe6
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1906391
Reviewed-by: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Let's make sure any change to files used explicitly in Cr50 are
approved by relevant persons.
BRANCH=none
BUG=none
TEST=none
Change-Id: If6affd837063311e3215e7596a3a424dc56c7603
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1919649
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the CONFIG_BATTERY_CHECK_CHARGE_TEMP_LIMITS option so that
when charging stops due to battery overtemperature, the battery LED
will be green regardless of the state of charge of the battery.
BUG=b:140596424
BRANCH=None
TEST=`make -j BOARD=kohaku && ./util/flash_ec --board=kohaku`
Ensure battery is not fully charged
LED is blue
Plug in AC adapter
LED is still blue
Close lid
LED turns red
Access EC console
> batttempfake 3300
This overrides the normal temperature read and forces the value to
330.0 K, which is 56.9 C. The Kohaku battery has a maximum charge
temperature of 55 C, and a maximum discharge temperature of 60 C,
so this temperature is hot enough to stop charging, but not so hot
that the system will shut down.
LED turns green
Unplug the power adapter
LED turns off
Plug in the power adapter
LED turns green
> batttempfake -1
LED turns red
Unplug the power adapter
LED turns off
Plug in the power adapter
LED turns red
Unplug the power adapter
LED turns off
> batttempfake 3300
Plug in the power adapter
LED turns green
Change-Id: Ie9f5032fbb5666b02bec86d3f7f474d30e759338
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1919401
Reviewed-by: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a check for the battery temperature in the safe range to charge
the battery, and if it isn't, stop charging. The battery information
defines minimum and maximum temperatures for discharge and for charge.
The state machine already checks if the battery temperature is outside
of the range for discharge (as part of is_battery_critical) and will
shut down the system completely if the battery temperature is out of
range. However, the temperature range for charging is usually tigheter
than for discharging, and it can be safe to discharge, but unsafe to
charge. For example, Kohaku specifies a maximum charge temperature of
55 C, and a maximum discharge temperature of 60 C. If the battery is
at 57 C, we don't want to charge, but it's still OK to use the system.
The check is enabled by CONFIG_BATTERY_CHECK_CHARGE_TEMP_LIMITS.
BUG=b:140596424
BRANCH=None
TEST=`make buildall -j` builds with no errors.
No boards have enabled CONFIG_BATTERY_CHECK_CHARGE_TEMP_LIMITS, so
no effect.
Change-Id: I3b76eab942ca3ef3871f0909395e91634db5640e
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1914510
Reviewed-by: Scott Collyer <scollyer@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Should enable charge first then the charge port can function normally.
Besides, for device using mt6370 and in force discharge mode,
mt6370 would receive a DPDM detach event and release BC1.2
charge supply info. We should force BC1.2 detection again to
recognize BC1.2 device again.
TEST=on krane 'ectool chargecontrol discharge;
ectool chargecontrol normal' and see the charge is
charging.
BUG=b:143045248
BRANCH=kukui
Change-Id: I72481dfddf48b1e274d8d81f8d9223ccb8295c72
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1916160
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a few issues in touchpad_updater, that is used only for
early bringup by Elan:
- Fix Makefile to correctly cross-compile
- Add support for 0x10 IC
- Improve debugging
- Remove manual fragmentation of USB bulk packets (this is not
required and actually breaks large transactions)
- Add timeout to libusb_bulk_transfer calls.
BRANCH=kukui
BUG=b:142333653
TEST=emerge-kukui -v ec-devutils && \
scp /build/kukui/usr/sbin/ec_touchpad_updater $IP:/usr/local/sbin
Ping-pong between 2 images:
ec_touchpad_updater -p 0x503c -f S8648A-15H0_FW01.bin
ec_touchpad_updater -p 0x503c -f S8648A-15H0_FWB1.bin
Change-Id: I78a8064002504ba4db15e202e516e7a2399bf648
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1906393
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change ensure the eDP backlight control is driven high so that the
PCH can turn the backlight on and off. Still need to add controls to the
EC to turn the backlight off.
BUG=b:144520387
BRANCH=none
TEST=make buildall
TEST=verify backlight on Volteer
Change-Id: Idb075781dc358c5c7a6fe68f828a28407b92c94d
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1918005
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Volteer, to avoid leakage from PP3300_A rail to PP5000 rail, turn on
the PP3300 rail before PP5000.
BUG=none
BRANCH=none
TEST=make buildall -j
TEST=verify Volteer transitions to S0
Change-Id: Ic86f97dbdde6d6c904fe7efc8b0edc1ead727cf6
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1918603
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add additional debug output for Ice Lake and Tiger Lake power sequencing
when the CONFIG_BRINGUP option is enabled.
BUG=none
BRANCH=none
TEST=make buildall
TEST=Verify debug messages on Volteer when CONFIG_BRINGUP is enabled.
Change-Id: I80fc23f470818af7a4dad73a7ad77bc9ba42d537
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1918602
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Volteer requires delay on RSMRST to meet power sequencing requirements.
BUG=none
BRANCH=none
TEST=make buildall
TEST=Verify Volteer powers on to S0
Change-Id: I927856a49a7a74b8908d6b7340abd60d926ec888
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1918601
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that these initializer/reset macros
can be used as a reset value (after initialization).
BRANCH=nocturne,nami
BUG=none
TEST=make buildall -j
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I5f4675399c87d959235b09e04c04e3613834421a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1917580
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add config for INA3221 power monitor sensors.
BRANCH=none
BUG=b:144127082
TEST=EC buildall
Change-Id: I87b3da86403b0ec7314b4084bc710c59f019930d
Signed-off-by: Andrew McRae <amcrae@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1915481
Tested-by: Andrew McRae <amcrae@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the reasoning behind the design pattern of
placing all params in one struct.
BRANCH=none
BUG=none
TEST=Examined in Gitlies
Change-Id: I80f29468126c3a3a36363c857d52d3baad785638
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1880578
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:139428185
BRANCH=none
TEST=verify mode is set correctly when switching devices
Change-Id: I266a399966bb90709bd3395405a67d3a1f49c2f9
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1911292
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add bc12 workaround when bc12 detect SDP
BRANCH=kukui
BUG=b:128049211
TEST=boot kukui, slow plug in DCP, check bc12 detect chg type
Change-Id: Ie9b8780fdad6e061e967ebb127b27bf63a11db2e
Signed-off-by: Gene Chen <gene_chen@mediatek.corp-partner.google.com>
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1568887
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add driver for TI INA3221 voltage sensors.
Puff has several of these devices, and the EC has access to them.
BRANCH=none
BUG=b:144132145
TEST=EC buildall, tests
Change-Id: I37efd6ce7f154339f002c633e5daf6a18fef05aa
Signed-off-by: Andrew McRae <amcrae@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1903629
Reviewed-by: Shelley Chen <shchen@chromium.org>
Reviewed-by: Andrew McRae <amcrae@chromium.org>
Tested-by: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=b:139428185
BRANCH=none
TEST=verify mode is set correctly when switching devices
Change-Id: Ic9d460a94bb8007f17168ac5237a4dcbc24cfb2b
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1900123
Reviewed-by: Edward Hill <ecgh@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update the GPIO and USB/I2C port lists following the Endeavour schematic
- Endeavour does not use a software-controlled TCPC so remove USB PD
- Remove LED panel
- Remove CEC
- Add OEM_ID
BUG=b:143780700
TEST=emerge-endeavour chromeos/ec
Change-Id: Idb554a4f87369ea1c42de0a1532ce11d28e4da56
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1902407
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Jeff Chase <jnchase@google.com>
Tested-by: Jeff Chase <jnchase@google.com>
|