diff options
Diffstat (limited to 'test/ec_comm.c')
| -rw-r--r-- | test/ec_comm.c | 270 |
1 files changed, 236 insertions, 34 deletions
diff --git a/test/ec_comm.c b/test/ec_comm.c index ba92e3132d..c24f968442 100644 --- a/test/ec_comm.c +++ b/test/ec_comm.c @@ -51,6 +51,14 @@ union cr50_test_packet sample_packet_cmd_verify_hash = { .ph.size = SHA256_DIGEST_SIZE, }; +#if CONFIG_EC_EFS2_VERSION == 0 +#define EXPECTED_BOOT_MODE_AFTER_EC_RST EC_EFS_BOOT_MODE_NORMAL +#define EXPECTED_BOOT_MODE_AFTER_VERIFY EC_EFS_BOOT_MODE_NORMAL +#elif CONFIG_EC_EFS2_VERSION == 1 +#define EXPECTED_BOOT_MODE_AFTER_EC_RST EC_EFS_BOOT_MODE_TRUSTED_RO +#define EXPECTED_BOOT_MODE_AFTER_VERIFY EC_EFS_BOOT_MODE_VERIFIED +#endif + /* EC Reset Count. It is used to see if ec has been reset. */ static int ec_reset_count_; @@ -185,7 +193,7 @@ static int test_ec_comm_packet_failure(void) ec_has_reset(); - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == EXPECTED_BOOT_MODE_AFTER_EC_RST); /* Test 1: Test with less preambles than required. */ calculate_crc8(&pk); @@ -227,7 +235,7 @@ static int test_ec_comm_packet_failure(void) /* Check if ec has ever been reset during these tests */ TEST_ASSERT(!ec_has_reset()); - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == EXPECTED_BOOT_MODE_AFTER_EC_RST); return EC_SUCCESS; } @@ -240,52 +248,97 @@ static int test_ec_comm_set_boot_mode(void) /* Copy the sample packet to buffer. */ union cr50_test_packet pk = sample_packet_cmd_set_mode; int preambles; + uint8_t boot_mode_expected; ec_has_reset(); - /* Test 1: Attempt to set boot mode to NORMAL. */ - pk.ph.data[0] = EC_EFS_BOOT_MODE_NORMAL; + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* + * Test 1-1: Attempt to set boot mode to EXPECTED_BOOT_MODE_AFTER_EC_RST + * NORMAL -> NORMAL (in 2.0) or RO -> RO (in 2.1) + */ + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; + pk.ph.data[0] = boot_mode_expected; calculate_crc8(&pk); preambles = MIN_LENGTH_PREAMBLE * 2; TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_SUCCESS)); TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); - /* Test 2: Attempt to set boot mode to NORMAL again. */ + /* + * Test 1-1: Attempt to set boot mode to EXPECTED_BOOT_MODE_AFTER_EC_RST + * NORMAL -> NORMAL (in 2.0) or RO -> RO (in 2.1) + */ + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; preambles = MIN_LENGTH_PREAMBLE; TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_SUCCESS)); TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); +#if CONFIG_EC_EFS2_VERSION == 1 /* - * Test 3: Attempt to set boot mode to NO BOOT. - * EC should not be reset with this boot mode change from NORMAL - * to NO_BOOT. + * Test 1-3: Attempt to set boot mode to BOOT_MODE_VERIFIED. + * It should fail. + * RO -> VERIFIED (x) RO (o) */ - pk.ph.data[0] = EC_EFS_BOOT_MODE_NO_BOOT; + boot_mode_expected = EC_EFS_BOOT_MODE_TRUSTED_RO; + pk.ph.data[0] = EC_EFS_BOOT_MODE_VERIFIED; + calculate_crc8(&pk); + TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_ERROR_BAD_PARAM)); + TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); +#endif + + /* + * Test 2-1: Attempt to set boot mode to NO BOOT. + * EC should not be reset with this boot mode change from + * BOOT_MODE_TRUSTED_RO to BOOT_MODE_NO_BOOT. + * INITIAL(RO or NORMAL) -> NO_BOOT + */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; + pk.ph.data[0] = boot_mode_expected; calculate_crc8(&pk); TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_SUCCESS)); TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NO_BOOT); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); /* - * Test 4: Attempt to set boot mode to NO BOOT again. - * EC should not be reset since it is a repeating command. + * Test 2-2: Attempt to set boot mode to NO BOOT again. + * EC should not be reset since it is a repeating command. + * NO_BOOT -> NO_BOOT */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_SUCCESS)); TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NO_BOOT); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + +#if CONFIG_EC_EFS2_VERSION == 1 + /* + * Test 2-3: Attempt to set boot mode to VERIFIED. It should fail. + * NO_BOOT -> VERIFIED (x) NO_BOOT(o) + */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; + pk.ph.data[0] = EC_EFS_BOOT_MODE_VERIFIED; + calculate_crc8(&pk); + TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_ERROR_BAD_PARAM)); + TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); +#endif /* - * Test 5: Attempt to set boot mode to NORMAL. - * EC should be reset with this boot mode change from NO_BOOT - * to NORMAL. + * Test 2-4: Attempt to set boot mode to BOOT_MODE_TRUSTED_RO. + * EC should be reset with this boot mode change from + * BOOT_MODE_NO_BOOT to BOOT_MODE_TRUSTED_RO. + * NO_BOOT -> NORMAL (in 2.0) or RO (in 2.1) */ - pk.ph.data[0] = EC_EFS_BOOT_MODE_NORMAL; + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; + pk.ph.data[0] = EXPECTED_BOOT_MODE_AFTER_EC_RST; calculate_crc8(&pk); TEST_ASSERT(!test_ec_comm(&pk, preambles, 0)); TEST_ASSERT(ec_has_reset()); /* EC must be reset. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); return EC_SUCCESS; } @@ -298,51 +351,185 @@ static int test_ec_comm_verify_hash(void) /* Copy the sample packet to buffer. */ union cr50_test_packet pk = sample_packet_cmd_verify_hash; int preambles = MIN_LENGTH_PREAMBLE; + uint8_t boot_mode_expected; ec_has_reset(); - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); - /* Test 1: Attempt to verify EC Hash. */ + /* + * Test 1: Attempt to verify EC Hash. + * NORMAL -> NORMAL (in 2.0) + * RO -> VERIFIED (in 2.1) + */ + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_VERIFY; calculate_crc8(&pk); preambles = MIN_LENGTH_PREAMBLE * 2; TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_SUCCESS)); TEST_ASSERT(!ec_has_reset()); - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); - /* Test 2: Attempt to verify EC Hash again. */ + /* + * Test 2: Attempt to verify EC Hash again. + * NORMAL -> NORMAL (in 2.0) + * VERIFIED -> VERIFIED (in 2.1) + */ + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_VERIFY; preambles = MIN_LENGTH_PREAMBLE; TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_SUCCESS)); TEST_ASSERT(!ec_has_reset()); - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); - /* Test 3: Attempt to verify a wrong EC Hash. */ + /* + * Test 3: Attempt to verify a wrong EC Hash. + * NORMAL -> NO_BOOT (in 2.0) + * VERIFIED -> NO_BOOT (in 2.1) + */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; pk.ph.data[0] ^= 0xff; /* corrupt the payload */ calculate_crc8(&pk); TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_ERROR_BAD_PAYLOAD)); TEST_ASSERT(!ec_has_reset()); /* EC should not be reset though. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NO_BOOT); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); - /* Test 4: Attempt to verify a wrong EC Hash again. */ - TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_ERROR_BAD_PAYLOAD)); + /* + * Test 4: Attempt to verify a wrong EC Hash again. + * NO_BOOT -> NO_BOOT + */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; + TEST_ASSERT(!test_ec_comm(&pk, preambles, + CR50_COMM_ERROR_BAD_PAYLOAD)); TEST_ASSERT(!ec_has_reset()); /* EC should not be reset though. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NO_BOOT); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); /* * Test 5: Attempt to verify the correct EC Hash. * EC should be reset because EC Boot mode is NO BOOT. + * NO_BOOT -> INITIAL */ + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; pk = sample_packet_cmd_verify_hash; calculate_crc8(&pk); preambles = MIN_LENGTH_PREAMBLE * 2; TEST_ASSERT(!test_ec_comm(&pk, preambles, 0)); TEST_ASSERT(ec_has_reset()); /* EC must be reset. */ - TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_NORMAL); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* Check if ec has ever been reset during these tests */ + return EC_SUCCESS; +} + +/* + * Test cases for verify_hash command failure case. + */ +static int test_ec_comm_verify_hash_fail(void) +{ + /* Copy the sample packet to buffer. */ + union cr50_test_packet pk = sample_packet_cmd_verify_hash; + int preambles = MIN_LENGTH_PREAMBLE; + uint8_t boot_mode_expected; + + ec_has_reset(); + + boot_mode_expected = EXPECTED_BOOT_MODE_AFTER_EC_RST; + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* + * Test 1: Attempt to verify a wrong EC Hash. + * RO -> NO_BOOT + */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; + pk.ph.data[0] ^= 0xff; /* corrupt the payload */ + calculate_crc8(&pk); + TEST_ASSERT(!test_ec_comm(&pk, preambles, CR50_COMM_ERROR_BAD_PAYLOAD)); + TEST_ASSERT(!ec_has_reset()); /* EC should not be reset though. */ + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + /* Check if ec has ever been reset during these tests */ return EC_SUCCESS; } +#if CONFIG_EC_EFS2_VERSION == 1 +/* + * Test cases for EC-EFS 2.1 protocols + */ +static int test_ec_comm_verify_efs2_1(void) +{ + /* Copy the sample packet to buffer. */ + union cr50_test_packet pk_verify = sample_packet_cmd_verify_hash; + union cr50_test_packet pk_set_bootmode = sample_packet_cmd_set_mode; + int preambles = MIN_LENGTH_PREAMBLE; + uint8_t boot_mode_expected; + + ec_has_reset(); + + boot_mode_expected = EC_EFS_BOOT_MODE_TRUSTED_RO; + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* + * Test 1-1: Attempt to verify EC Hash while RO. + * RO -> VERIFIED + */ + boot_mode_expected = EC_EFS_BOOT_MODE_VERIFIED; + calculate_crc8(&pk_verify); + TEST_ASSERT(!test_ec_comm(&pk_verify, preambles, CR50_COMM_SUCCESS)); + TEST_ASSERT(!ec_has_reset()); + TEST_ASSERT(ec_efs_get_boot_mode() == EC_EFS_BOOT_MODE_VERIFIED); + + /* + * Test 1-2: Attempt to change BOOT_MODE to RO. Should fail. + * VERIFIED -> RO, EC Reset + */ + boot_mode_expected = EC_EFS_BOOT_MODE_TRUSTED_RO; + pk_set_bootmode.ph.data[0] = boot_mode_expected; + calculate_crc8(&pk_set_bootmode); + TEST_ASSERT(!test_ec_comm(&pk_set_bootmode, preambles, 0)); + TEST_ASSERT(ec_has_reset()); /* EC must not be reset. */ + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* + * Test 1-3: Attempt to change BOOT_MODE to VERIFIED. + * Should fail, since VERIFIED is not allowed + * as a parameter of SET_BOOT_MODE command. + * RO -> VERIFIED (x) RO(o) + */ + boot_mode_expected = EC_EFS_BOOT_MODE_TRUSTED_RO; + pk_set_bootmode.ph.data[0] = EC_EFS_BOOT_MODE_VERIFIED; + calculate_crc8(&pk_set_bootmode); + TEST_ASSERT(!test_ec_comm(&pk_set_bootmode, preambles, + CR50_COMM_ERROR_BAD_PARAM)); + TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* + * Test 1-4: Attempt to change BOOT_MODE to NO_BOOT. + * Should succeed + * VERIFIED -> NO_BOOT + */ + boot_mode_expected = EC_EFS_BOOT_MODE_NO_BOOT; + pk_set_bootmode.ph.data[0] = boot_mode_expected; + calculate_crc8(&pk_set_bootmode); + TEST_ASSERT(!test_ec_comm(&pk_set_bootmode, preambles, + CR50_COMM_SUCCESS)); + TEST_ASSERT(!ec_has_reset()); /* EC must not be reset. */ + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* + * Test 1-5: Attempt to verify EC Hash while NO_BOOT + * NO_BOOT -> RO + */ + boot_mode_expected = EC_EFS_BOOT_MODE_TRUSTED_RO; + TEST_ASSERT(!test_ec_comm(&pk_verify, preambles, 0)); + TEST_ASSERT(ec_has_reset()); + TEST_ASSERT(ec_efs_get_boot_mode() == boot_mode_expected); + + /* Check if ec has ever been reset during these tests */ + return EC_SUCCESS; +} +#endif /* CONFIG_EC_EFS2_VERSION == 1 */ + void run_test(void) { uint8_t size_to_crc; @@ -359,16 +546,31 @@ void run_test(void) test_secdata.crc8 = crc8((uint8_t *)&test_secdata.reserved0, size_to_crc); - /* Module init */ - board_reboot_ec_deferred(0); - ec_efs_refresh(); /* Start test */ test_reset(); + board_reboot_ec_deferred(0); + ec_efs_refresh(); RUN_TEST(test_ec_comm_packet_failure); + + board_reboot_ec_deferred(0); + ec_efs_refresh(); RUN_TEST(test_ec_comm_set_boot_mode); + + board_reboot_ec_deferred(0); + ec_efs_refresh(); RUN_TEST(test_ec_comm_verify_hash); + board_reboot_ec_deferred(0); + ec_efs_refresh(); + RUN_TEST(test_ec_comm_verify_hash_fail); + +#if CONFIG_EC_EFS2_VERSION == 1 + board_reboot_ec_deferred(0); + ec_efs_refresh(); + RUN_TEST(test_ec_comm_verify_efs2_1); +#endif + test_print_result(); } |