diff options
| author | Karthikeyan Ramasubramanian <kramasub@chromium.org> | 2019-06-12 11:30:49 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-22 15:12:11 +0000 |
| commit | 8b3577c2e46150d9ee9b3a2166c9e0ba0a5c15fe (patch) | |
| tree | ac41466ede81b4a0459451c0828231731bebe9a4 /util | |
| parent | 4936bb0bfeb48b7b141399f36ec44798542f0e50 (diff) | |
| download | chrome-ec-8b3577c2e46150d9ee9b3a2166c9e0ba0a5c15fe.tar.gz | |
ec_commands: Rename 'renew' to 'live' in EC_CMD_USB_PD_CHIP_INFO
Semantics of renew field in EC_CMD_USB_PD_CHIP_INFO is changing as
follows:
0 -> Return hard-coded info for Vendor ID/Product ID and cached info for
the Firmware Version
1 -> Return the live chip info for Vendor ID/Product ID/Firmware Version
Also rename the 'renew' field to 'live' to match the new semantics.
BUG=b:128820536,b:119046668
BRANCH=None
TEST=make -j buildall; Boot to ChromeOS.
Change-Id: Ie3dd022336b0be5c9728bb0ebabef32b7a6b5d57
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1617893
Tested-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Auto-Submit: Karthikeyan Ramasubramanian <kramasub@chromium.org>
(cherry picked from commit 5936367096413abf294aa4584df53ec80bf8ef4c)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1713105
Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/ectool.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/util/ectool.c b/util/ectool.c index aa124edf5e..64bb7fe056 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -8083,7 +8083,12 @@ int cmd_pd_chip_info(int argc, char *argv[]) int cmdver = 1; if (argc < 2 || 3 < argc) { - fprintf(stderr, "Usage: %s <port> [renew(on/off)]\n", argv[0]); + fprintf(stderr, "Usage: %s <port> [<live>]\n" + "live parameter can take values 0 or 1\n" + "0 -> Return hard-coded value for VID/PID and\n" + " cached value for Firmware Version\n" + "1 -> Return live chip value for VID/PID/FW Version\n", + argv[0]); return -1; } @@ -8093,14 +8098,13 @@ int cmd_pd_chip_info(int argc, char *argv[]) return -1; } - p.renew = 0; + p.live = 0; if (argc == 3) { - int val; - if (!parse_bool(argv[2], &val)) { + p.live = strtol(argv[2], &e, 0); + if (e && *e) { fprintf(stderr, "invalid arg \"%s\"\n", argv[2]); return -1; } - p.renew = val; } if (!ec_cmd_version_supported(EC_CMD_PD_CHIP_INFO, cmdver)) |