diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2017-08-02 10:59:39 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-08-03 15:13:58 -0700 |
| commit | e01813adc7dab9737b13f4846c29c9770b39e888 (patch) | |
| tree | c660a2fe5a36e93180e71e69b7ac3f5ce56b9c4f /util/presubmit_check.sh | |
| parent | 41a0dc443c84c9e3a79ed40499d9ee9c6962fbd0 (diff) | |
| download | chrome-ec-e01813adc7dab9737b13f4846c29c9770b39e888.tar.gz | |
presubmit_check: Don't include flash_ec.
One of the items that the presubmit check checks is that if any source
file has been modified, the unit tests are run again. However, flash_ec
is included in the list of files. This commit removes flash_ec from the
candidates because it's not run in any unit tests anyways and it's a
shell script that is not compiled.
Additionally, ignore changes to the presubmit_check.sh itself.
BUG=None
BRANCH=None
TEST=modify flash_ec, verify that presubmit check doesn't complain about
not running make buildall.
Change-Id: I473f269c7f0bba9be3216fcec39f266d896fb908
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/598505
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'util/presubmit_check.sh')
| -rwxr-xr-x | util/presubmit_check.sh | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/util/presubmit_check.sh b/util/presubmit_check.sh index 0ba4776473..b4024dbfd8 100755 --- a/util/presubmit_check.sh +++ b/util/presubmit_check.sh @@ -11,8 +11,12 @@ fi changed=$(find ${PRESUBMIT_FILES} -newer .tests-passed) ec3po_files=$(echo "${PRESUBMIT_FILES}" | grep util/ec3po/) -# Filter out ec3po files from changed files. +# Filter out ec3po files from changed files. They're handled separately. changed=$(echo "${changed}" | grep -v util/ec3po/) +# Filter out flash_ec since it's not part of any unit tests. +changed=$(echo "${changed}" | grep -v util/flash_ec) +# Filter out this file itself. +changed=$(echo "${changed}" | grep -v util/presubmit_check.sh) if [[ -n "${changed}" ]]; then echo "Files have changed since last time unit tests passed:" echo "${changed}" | sed -e 's/^/ /' |