diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2012-10-15 14:58:37 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-10-15 17:47:01 -0700 |
| commit | aadfab96c0ccff88aefc161d07537604c9be4ba1 (patch) | |
| tree | 5c27440b0152fcc2673539dfcfcb090670c3465f /util/ectool.c | |
| parent | 4dd3940d19196fc3f872f08ec30d6d5a6ad8ef28 (diff) | |
| download | chrome-ec-aadfab96c0ccff88aefc161d07537604c9be4ba1.tar.gz | |
Fix lightbar bug, add more tweaks.
I introduced a glitch in the parameterization CL. This fixes it, and makes
the choice between the gentle throbbing and occasional pulse something that
can be selected as a parameter. Default is the new pulsey style.
BUG=chrome-os-partner:8039
BRANCH=Link
TEST=manual
Using the ectool that's part of this change, run these commands to flip
between suspend and active displays:
ectool lightbar seq s3s0
ectool lightbar seq s0s3
Change the "new_s0" value (0/1) and reload the params with
ectool lightbar params | tee /tmp/w
vi /tmp/w
ectool lightbar params /tmp/w
In each case you'll see some pretty patterns. Pass/Fail is an artistic
decision. No QA required.
Change-Id: I8de0b1b3cc77f65879befe95e110bbbce18846d9
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/35620
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'util/ectool.c')
| -rw-r--r-- | util/ectool.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/util/ectool.c b/util/ectool.c index 5eadc4b9f3..279a370256 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -1167,9 +1167,12 @@ static int lb_read_params_from_file(const char *filename, READ(1); p->s3s0_ramp_up = val[0]; READ(1); p->s0_tick_delay[0] = val[0]; READ(1); p->s0_tick_delay[1] = val[0]; + READ(1); p->s0a_tick_delay[0] = val[0]; + READ(1); p->s0a_tick_delay[1] = val[0]; READ(1); p->s0s3_ramp_down = val[0]; READ(1); p->s3_sleep_for = val[0]; READ(1); p->s3_tick_delay = val[0]; + READ(1); p->new_s0 = val[0]; READ(2); p->osc_min[0] = val[0]; @@ -1248,9 +1251,12 @@ static void lb_show_params(const struct lightbar_params *p) printf("%d\t\t# .s3s0_ramp_up\n", p->s3s0_ramp_up); printf("%d\t\t# .s0_tick_delay (battery)\n", p->s0_tick_delay[0]); printf("%d\t\t# .s0_tick_delay (AC)\n", p->s0_tick_delay[1]); + printf("%d\t\t# .s0a_tick_delay (battery)\n", p->s0a_tick_delay[0]); + printf("%d\t\t# .s0a_tick_delay (AC)\n", p->s0a_tick_delay[1]); printf("%d\t\t# .s0s3_ramp_down\n", p->s0s3_ramp_down); printf("%d\t# .s3_sleep_for\n", p->s3_sleep_for); printf("%d\t\t# .s3_tick_delay\n", p->s3_tick_delay); + printf("%d\t\t# .new_s0\n", p->new_s0); printf("0x%02x 0x%02x\t# .osc_min (battery, AC)\n", p->osc_min[0], p->osc_min[1]); printf("0x%02x 0x%02x\t# .osc_max (battery, AC)\n", |