diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2018-07-26 12:18:41 +0200 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-07-30 23:08:00 -0700 |
| commit | d21c0a90c374b88e09f173de42ed9a388f84f169 (patch) | |
| tree | 6ce9e96aa0ca8650d9e949ff5e1407a914727ca3 /util/cbi-util.c | |
| parent | 168897eb1d07b8cdeee74fa2a3bf73f7147121ae (diff) | |
| download | chrome-ec-d21c0a90c374b88e09f173de42ed9a388f84f169.tar.gz | |
util/cbi-util: Check pointer before using it
Change-Id: If11de8883b001f16d7e8f859a416fbdc5ea0391a
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #187038
Reviewed-on: https://chromium-review.googlesource.com/1151121
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'util/cbi-util.c')
| -rw-r--r-- | util/cbi-util.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/cbi-util.c b/util/cbi-util.c index 5db416fbe4..23d9986348 100644 --- a/util/cbi-util.c +++ b/util/cbi-util.c @@ -333,11 +333,13 @@ static void print_integer(const uint8_t *buf, enum cbi_data_tag tag) { uint32_t v; struct cbi_data *d = cbi_find_tag(buf, tag); - const char *name = d->tag < CBI_TAG_COUNT ? field_name[d->tag] : "???"; + const char *name; if (!d) return; + name = d->tag < CBI_TAG_COUNT ? field_name[d->tag] : "???"; + switch (d->size) { case 1: v = *(uint8_t *)d->value; |