summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorVadim Bendebury <vbendeb@chromium.org>2017-01-08 16:17:35 -0800
committerchrome-bot <chrome-bot@chromium.org>2017-01-09 23:47:05 -0800
commit8734b70ff56e48900e4aaa68c1c56e84d60ce2ac (patch)
treefe630865e2e1259febb5356d042d39a9f4594f5d /test
parent2ddd8d8e5fc123e75b9720ee26fdcc3e85de51ad (diff)
downloadchrome-ec-8734b70ff56e48900e4aaa68c1c56e84d60ce2ac.tar.gz
test: nvmem_vars: drop redundant erase_flash() invocations
There is no need to invoke erase_flash() before load_flash(), as load_flash() invokes that function itself. BRANCH=none BUG=none TEST=make buildall -j still passes Change-Id: Ic4aba9f680402418ec6268d6ed5800065a09110b Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/426087 Reviewed-by: Bill Richardson <wfrichar@chromium.org> Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Diffstat (limited to 'test')
-rw-r--r--test/nvmem_vars.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/test/nvmem_vars.c b/test/nvmem_vars.c
index 7a0333e525..1ea2a312c6 100644
--- a/test/nvmem_vars.c
+++ b/test/nvmem_vars.c
@@ -186,12 +186,10 @@ static int check_init(void)
[513] = 0x01, [514] = 0x52, /* 513-598 */
[599] = 0xff };
- erase_flash();
load_flash(good, sizeof(good));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(good, sizeof(good)));
- erase_flash();
load_flash(empty, sizeof(empty));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(empty, sizeof(empty)));
@@ -201,27 +199,22 @@ static int check_init(void)
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(empty, sizeof(empty)));
- erase_flash();
load_flash(bad_key, sizeof(bad_key));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(empty, sizeof(empty)));
- erase_flash();
load_flash(bad_val, sizeof(bad_val));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(empty, sizeof(empty)));
- erase_flash();
load_flash(too_big, sizeof(too_big));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(empty, sizeof(empty)));
- erase_flash();
load_flash(just_right, sizeof(just_right));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(just_right, sizeof(just_right)));
- erase_flash();
load_flash(not_right, sizeof(not_right));
TEST_ASSERT(initvars() == EC_SUCCESS);
TEST_ASSERT(verify_flash(empty, sizeof(empty)));