summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorMary Ruthven <mruthven@chromium.org>2021-11-19 09:34:02 -0600
committerCommit Bot <commit-bot@chromium.org>2021-11-19 21:33:05 +0000
commit6d5efa406b96158e8f519064f5e377f60147cdc3 (patch)
tree3101f02d1f11ab1e7557a4534085bb813c68a924 /test
parentfabb25e9ebaa3f44adcd6e369c24e54021a9299b (diff)
downloadchrome-ec-6d5efa406b96158e8f519064f5e377f60147cdc3.tar.gz
coil: replace non-inclusive terms with "placeholder"
BUG=b:173227629 TEST=make buildall -j Change-Id: I2b203dfe45416aa3b632f6f788d14264b08f44e0 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3293252 Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Diffstat (limited to 'test')
-rw-r--r--test/queue.c10
-rw-r--r--test/rma_auth.c24
-rw-r--r--test/stress.c8
-rw-r--r--test/thermal.c2
-rw-r--r--test/tpm_test/testlib/trng.h2
-rw-r--r--test/tpm_test/testlib/util.h2
6 files changed, 24 insertions, 24 deletions
diff --git a/test/queue.c b/test/queue.c
index 664cde572e..79df79fa22 100644
--- a/test/queue.c
+++ b/test/queue.c
@@ -17,12 +17,12 @@ static struct queue const test_queue2 = QUEUE_NULL(2, int16_t);
static int test_queue8_empty(void)
{
- char dummy = 1;
+ char placeholder = 1;
queue_init(&test_queue8);
TEST_ASSERT(queue_is_empty(&test_queue8));
- TEST_ASSERT(!queue_remove_units(&test_queue8, &dummy, 1));
- TEST_ASSERT(queue_add_units(&test_queue8, &dummy, 1) == 1);
+ TEST_ASSERT(!queue_remove_units(&test_queue8, &placeholder, 1));
+ TEST_ASSERT(queue_add_units(&test_queue8, &placeholder, 1) == 1);
TEST_ASSERT(!queue_is_empty(&test_queue8));
return EC_SUCCESS;
@@ -30,10 +30,10 @@ static int test_queue8_empty(void)
static int test_queue8_init(void)
{
- char dummy = 1;
+ char placeholder = 1;
queue_init(&test_queue8);
- TEST_ASSERT(queue_add_units(&test_queue8, &dummy, 1) == 1);
+ TEST_ASSERT(queue_add_units(&test_queue8, &placeholder, 1) == 1);
queue_init(&test_queue8);
TEST_ASSERT(queue_is_empty(&test_queue8));
diff --git a/test/rma_auth.c b/test/rma_auth.c
index 21f2f2d561..129cc70383 100644
--- a/test/rma_auth.c
+++ b/test/rma_auth.c
@@ -17,9 +17,9 @@
#include "timer.h"
#include "util.h"
-/* Dummy implementations for testing */
-static uint8_t dummy_board_id[4] = {'Z', 'Z', 'C', 'R'};
-static uint8_t dummy_device_id[8] = {'T', 'H', 'X', 1, 1, 3, 8, 0xfe};
+/* Placeholder implementations for testing */
+static uint8_t placeholder_board_id[4] = {'Z', 'Z', 'C', 'R'};
+static uint8_t placeholder_device_id[8] = {'T', 'H', 'X', 1, 1, 3, 8, 0xfe};
static int server_protocol_version = RMA_CHALLENGE_VERSION;
static uint8_t server_private_key[32] = RMA_TEST_SERVER_PRIVATE_KEY;
static int server_key_id = RMA_TEST_SERVER_KEY_ID;
@@ -35,7 +35,7 @@ void rand_bytes(void *buffer, size_t len)
int read_board_id(struct board_id *id)
{
- memcpy(&id->type, dummy_board_id, sizeof(id->type));
+ memcpy(&id->type, placeholder_board_id, sizeof(id->type));
id->type_inv = ~id->type;
id->flags = 0xFF00;
return EC_SUCCESS;
@@ -43,8 +43,8 @@ int read_board_id(struct board_id *id)
int system_get_chip_unique_id(uint8_t **id)
{
- *id = dummy_device_id;
- return sizeof(dummy_device_id);
+ *id = placeholder_device_id;
+ return sizeof(placeholder_device_id);
}
/**
@@ -101,11 +101,11 @@ int rma_server_side(char *out_auth_code, const char *challenge)
* Since this is just a test, here we'll just make sure the BoardID
* and DeviceID match what we expected.
*/
- if (memcmp(c.board_id, dummy_board_id, sizeof(c.board_id))) {
+ if (memcmp(c.board_id, placeholder_board_id, sizeof(c.board_id))) {
printf("BoardID mismatch\n");
return -1;
}
- if (memcmp(c.device_id, dummy_device_id, sizeof(c.device_id))) {
+ if (memcmp(c.device_id, placeholder_device_id, sizeof(c.device_id))) {
printf("DeviceID mismatch\n");
return -1;
}
@@ -193,13 +193,13 @@ static int test_rma_auth(void)
TEST_ASSERT(rma_server_side(authcode, challenge) == -1);
server_key_id--;
- dummy_board_id[0]++;
+ placeholder_board_id[0]++;
TEST_ASSERT(rma_server_side(authcode, challenge) == -1);
- dummy_board_id[0]--;
+ placeholder_board_id[0]--;
- dummy_device_id[0]++;
+ placeholder_device_id[0]++;
TEST_ASSERT(rma_server_side(authcode, challenge) == -1);
- dummy_device_id[0]--;
+ placeholder_device_id[0]--;
return EC_SUCCESS;
}
diff --git a/test/stress.c b/test/stress.c
index 442c4b498e..aa7c604765 100644
--- a/test/stress.c
+++ b/test/stress.c
@@ -79,25 +79,25 @@ static int stress(const char *name,
static int test_i2c(void)
{
int res = EC_ERROR_UNKNOWN;
- int dummy_data;
+ int placeholder_data;
struct i2c_test_param_t *param;
param = i2c_test_params + (prng_no_seed() % (sizeof(i2c_test_params) /
sizeof(struct i2c_test_param_t)));
if (param->width == 8 && param->data == -1)
res = i2c_read8(param->port, param->addr,
- param->offset, &dummy_data);
+ param->offset, &placeholder_data);
else if (param->width == 8 && param->data >= 0)
res = i2c_write8(param->port, param->addr,
param->offset, param->data);
else if (param->width == 16 && param->data == -1)
res = i2c_read16(param->port, param->addr,
- param->offset, &dummy_data);
+ param->offset, &placeholder_data);
else if (param->width == 16 && param->data >= 0)
res = i2c_write16(param->port, param->addr,
param->offset, param->data);
else if (param->width == 32 && param->data == -1)
res = i2c_read32(param->port, param->addr,
- param->offset, &dummy_data);
+ param->offset, &placeholder_data);
else if (param->width == 32 && param->data >= 0)
res = i2c_write32(param->port, param->addr,
param->offset, param->data);
diff --git a/test/thermal.c b/test/thermal.c
index 6f6a7cd358..922b58da78 100644
--- a/test/thermal.c
+++ b/test/thermal.c
@@ -38,7 +38,7 @@ static int cpu_shutdown;
static int fan_pct;
static int no_temps_read;
-int dummy_temp_get_val(int idx, int *temp_ptr)
+int placeholder_temp_get_val(int idx, int *temp_ptr)
{
if (mock_temp[idx] >= 0) {
*temp_ptr = mock_temp[idx];
diff --git a/test/tpm_test/testlib/trng.h b/test/tpm_test/testlib/trng.h
index 07c82f3333..25ff00b4f7 100644
--- a/test/tpm_test/testlib/trng.h
+++ b/test/tpm_test/testlib/trng.h
@@ -3,4 +3,4 @@
* found in the LICENSE file.
*/
-/* Dummy empty file, just to make test compilation work. */
+/* Placeholder empty file, just to make test compilation work. */
diff --git a/test/tpm_test/testlib/util.h b/test/tpm_test/testlib/util.h
index 07c82f3333..25ff00b4f7 100644
--- a/test/tpm_test/testlib/util.h
+++ b/test/tpm_test/testlib/util.h
@@ -3,4 +3,4 @@
* found in the LICENSE file.
*/
-/* Dummy empty file, just to make test compilation work. */
+/* Placeholder empty file, just to make test compilation work. */