diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /power/common.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'power/common.c')
| -rw-r--r-- | power/common.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/power/common.c b/power/common.c index cdefe38b9a..1916758482 100644 --- a/power/common.c +++ b/power/common.c @@ -575,8 +575,7 @@ static int command_powerinfo(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(powerinfo, command_powerinfo, NULL, - "Show current power state", - NULL); + "Show current power state"); #ifdef CONFIG_CMD_POWERINDEBUG static int command_powerindebug(int argc, char **argv) @@ -611,8 +610,7 @@ static int command_powerindebug(int argc, char **argv) }; DECLARE_CONSOLE_COMMAND(powerindebug, command_powerindebug, "[mask]", - "Get/set power input debug mask", - NULL); + "Get/set power input debug mask"); #endif #ifdef CONFIG_HIBERNATE @@ -640,8 +638,7 @@ static int command_hibernation_delay(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(hibdelay, command_hibernation_delay, "[sec]", - "Set the delay before going into hibernation", - NULL); + "Set the delay before going into hibernation"); static int host_command_hibernation_delay(struct host_cmd_handler_args *args) { @@ -703,8 +700,7 @@ static int command_pause_in_s5(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(pause_in_s5, command_pause_in_s5, "[on|off]", - "Should the AP pause in S5 during shutdown?", - NULL); + "Should the AP pause in S5 during shutdown?"); #endif /* CONFIG_POWER_SHUTDOWN_PAUSE_IN_S5 */ #ifdef CONFIG_POWER_TRACK_HOST_SLEEP_STATE |