diff options
author | Shawn Nematbakhsh <shawnn@chromium.org> | 2015-03-11 18:09:30 -0700 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-03-17 01:42:30 +0000 |
commit | 746debdf20a647fbe0e197f8a6c7b0597bc6a27f (patch) | |
tree | 11f04a0d74e583f71d0e7cab4c6007db52384fbc /include | |
parent | fa671e65917b6673250af23e58372bcec272ca0e (diff) | |
download | chrome-ec-746debdf20a647fbe0e197f8a6c7b0597bc6a27f.tar.gz |
spi_flash: Rework protection translation functions
Previously we defined separate functions to map registers to protect
ranges for each supported SPI ROM. This change instead adds a protect range
table + flags for each supported SPI ROM and adds common functions for
translation between ranges + registers. This makes supporting new parts
easier. Since we will never use most supported protection ranges, we can
even simplfy the tables.
The implementation is now similar to flashrom.
BUG=chrome-os-partner:37688
TEST=Manual on Glower.
flashwp disable + spi_flash_rsr --> 0
flashinfo --> shows no protection
spi_flash_prot 0 0x10000 + spi_flash_rsr --> 0x24
flashinfo --> shows 64KB protected
spi_flash_prot 0 0x20000 + spi_flash_rsr --> 0x28
flashinfo --> shows all 96KB protected
spi_flash_prot 0 0x40000 + spi_flash_rsr --> 0x2c
spi_flash_prot 0 0x80000 + spi_flash_rsr --> 0x10
spi_flash_prot 0 0 + spi_flash_rsr --> 0x00
spi_flash_prot 0 0x1000 --> error
spi_flash_prot 0x10000 0x10000 --> error
BRANCH=None
Change-Id: Ie5908ce687b7ff207b09794c7b001a4fbd9e0f5a
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/259310
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/config.h | 3 | ||||
-rw-r--r-- | include/spi_flash_reg.h | 68 |
2 files changed, 71 insertions, 0 deletions
diff --git a/include/config.h b/include/config.h index eee74b4389..c83258b215 100644 --- a/include/config.h +++ b/include/config.h @@ -1045,6 +1045,9 @@ /* Support W25X40 SPI flash */ #undef CONFIG_SPI_FLASH_W25X40 +/* SPI flash part supports SR2 register */ +#undef CONFIG_SPI_FLASH_HAS_SR2 + /* Size (bytes) of SPI flash memory */ #undef CONFIG_SPI_FLASH_SIZE diff --git a/include/spi_flash_reg.h b/include/spi_flash_reg.h new file mode 100644 index 0000000000..de9737e4bc --- /dev/null +++ b/include/spi_flash_reg.h @@ -0,0 +1,68 @@ +/* + * Copyright 2015 The Chromium OS Authors. All rights reserved. + * Use of this source code is governed by a BSD-style license that can be + * found in the LICENSE file. + * + * SPI flash protection register translation functions for Chrome OS EC. + */ + +#ifndef __CROS_EC_SPI_FLASH_REGS_H +#define __CROS_EC_SPI_FLASH_REGS_H + +#include "common.h" + +/* + * Common register bits for SPI flash. All registers / bits may not be valid + * for all parts. + */ +#define SPI_FLASH_SR2_SUS (1 << 7) +#define SPI_FLASH_SR2_CMP (1 << 6) +#define SPI_FLASH_SR2_LB3 (1 << 5) +#define SPI_FLASH_SR2_LB2 (1 << 4) +#define SPI_FLASH_SR2_LB1 (1 << 3) +#define SPI_FLASH_SR2_QE (1 << 1) +#define SPI_FLASH_SR2_SRP1 (1 << 0) +#define SPI_FLASH_SR1_SRP0 (1 << 7) +#define SPI_FLASH_SR1_SEC (1 << 6) +#define SPI_FLASH_SR1_TB (1 << 5) +#define SPI_FLASH_SR1_BP2 (1 << 4) +#define SPI_FLASH_SR1_BP1 (1 << 3) +#define SPI_FLASH_SR1_BP0 (1 << 2) +#define SPI_FLASH_SR1_WEL (1 << 1) +#define SPI_FLASH_SR1_BUSY (1 << 0) + +/* SR2 register existence based upon chip */ +#ifdef CONFIG_SPI_FLASH_W25X40 +#undef CONFIG_SPI_FLASH_HAS_SR2 +#elif defined(CONFIG_SPI_FLASH_W25Q64) +#define CONFIG_SPI_FLASH_HAS_SR2 +#endif + +/** + * Computes block write protection range from registers + * Returns start == len == 0 for no protection + * + * @param sr1 Status register 1 + * @param sr2 Status register 2 + * @param start Output pointer for protection start offset + * @param len Output pointer for protection length + * + * @return EC_SUCCESS, or non-zero if any error. + */ +int spi_flash_reg_to_protect(uint8_t sr1, uint8_t sr2, unsigned int *start, + unsigned int *len); + +/** + * Computes block write protection registers from range + * + * @param start Desired protection start offset + * @param len Desired protection length + * @param sr1 Output pointer for status register 1 + * @param sr2 Output pointer for status register 2 + * + * @return EC_SUCCESS, or non-zero if any error. + */ +int spi_flash_protect_to_reg(unsigned int start, unsigned int len, uint8_t *sr1, + uint8_t *sr2); + +#endif /* __CROS_EC_SPI_FLASH_REGS_H */ |