diff options
| author | Randall Spangler <rspangler@chromium.org> | 2011-12-19 13:36:18 -0800 |
|---|---|---|
| committer | Randall Spangler <rspangler@chromium.org> | 2011-12-19 13:48:05 -0800 |
| commit | 84a286b1f49c25df1d44bbf87d748b20421f5521 (patch) | |
| tree | cdfb346f7d5690921d96dc657bca4a07723321ff /include/task.h | |
| parent | 117021278ca6a3069c7bb8c55868a2f40530ae1a (diff) | |
| download | chrome-ec-84a286b1f49c25df1d44bbf87d748b20421f5521.tar.gz | |
Use #defined constants for IRQ names
Signed-off-by: Randall Spangler <rspangler@chromium.org>
BUG=none
TEST=none
Change-Id: If07ac671cef6b9d0e9fe0a96bf04455a3d2626ff
Diffstat (limited to 'include/task.h')
| -rw-r--r-- | include/task.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/include/task.h b/include/task.h index 8db98c26f9..52e42d3740 100644 --- a/include/task.h +++ b/include/task.h @@ -91,9 +91,10 @@ struct irq_priority { * Connects the interrupt handler "routine" to the irq number "irq" and * ensures it is enabled in the interrupt controller with the right priority. * - * Note that you MUST pass irq as the number ("5") not as a #defined constant, - * because it's stringized and matched up with a weak reference from init.S. - * TODO: fix that; it's typo-prone. + * Note that you MUST pass irq using a LM4_IRQ_* constant from register.h, not + * as a number, because it's stringized and matched up with a weak reference + * from init.S. (This is still better than passing it as a raw number, because + * that's more typo-prone.) */ #define DECLARE_IRQ(irq, routine, priority) \ void irq_##irq##_handler(void) \ |