diff options
| author | Randall Spangler <rspangler@chromium.org> | 2017-08-17 12:02:45 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-08-23 17:01:21 -0700 |
| commit | b91ff0a480304a8b831e943d7b62c528c16b2e83 (patch) | |
| tree | ec7b5081c8c8862636446af1b38f1a3f6fc719ab /include/device_state.h | |
| parent | c592ced088d9a252d62081e083dd8659770b7b93 (diff) | |
| download | chrome-ec-b91ff0a480304a8b831e943d7b62c528c16b2e83.tar.gz | |
cr50: Refactor Rdd state machine
The code to mirror Rdd detect into CCD_MODE_L and handle keepalive is
now inside chip/g/rdd.c It uses a HOOK_SECOND state machine similar to
what's coming for EC/AP/Servo.
This also removes the explicit 'ccd enable' / 'ccd disable' commands,
since they'd be overridden by the HOOK_SECOND handler. If you need to
force CCD enabled, use 'ccd keepalive enable'.
BUG=b:64799106
BRANCH=cr50
TEST=With a CR50_DEV=1 images:
Disconnect CCD cable (pull RDCC1 and RDCC2 outside 0.2-2.0V)
gpioget --> CCD_MODE_L = 1
ccd --> CCD disabled
Connect CCD cable --> see 'Debug accessory connected'
gpioget --> CCD_MODE_L = 0
ccd --> CCD enabled
Briefly disconnect and reconnect CCD cable --> No debug output
gpioget --> CCD_MODE_L = 0
ccd --> CCD enabled
Disconnect CCD cable and wait a second --> 'disconnected'
gpioget --> CCD_MODE_L = 1
ccd --> CCD disabled
Force CCD_MODE_L = 0 externally, wait a second
gpioget --> CCD_MODE_L = 0
ccd --> CCD enabled
Stop forcing CCD_MODE_L externally, wait a second
gpioget --> CCD_MODE_L = 1
ccd --> CCD disabled
ccd keepalive enable
gpioget --> CCD_MODE_L = 0
ccd --> CCD enabled
ccd keepalive disable
gpioget --> CCD_MODE_L = 1
ccd --> CCD disabled
Change-Id: I65110b45e76f60390828e0fbbac8f36fc2cc9b37
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/619393
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Diffstat (limited to 'include/device_state.h')
| -rw-r--r-- | include/device_state.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/include/device_state.h b/include/device_state.h index 7d22846d9e..e7894ba998 100644 --- a/include/device_state.h +++ b/include/device_state.h @@ -6,14 +6,6 @@ #ifndef __CROS_DEVICE_STATE_H #define __CROS_DEVICE_STATE_H -/* Device state indexes */ -enum device_state { - DEVICE_STATE_UNKNOWN = 0, - DEVICE_STATE_OFF, - DEVICE_STATE_ON, - DEVICE_STATE_COUNT, -}; - enum gpio_signal; /* Device configuration */ |