diff options
author | Allen Webb <allenwebb@google.com> | 2018-08-17 14:56:33 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-07 18:36:33 -0700 |
commit | 6a9a3a62732ff31e247a9eb61a5f4e7c53154ee5 (patch) | |
tree | 32a71c89e7266301206cc4dd242332bd5b835892 /include/common.h | |
parent | 09d4918f464b69390f0c2d12cdd8c6aeafcb2cae (diff) | |
download | chrome-ec-6a9a3a62732ff31e247a9eb61a5f4e7c53154ee5.tar.gz |
fuzz: Hide conflicts with cstdlib and use clang++ for linking.
This creates a build target called libec.a by setting the visibility
of functions that conflict with cstdlib to hidden. It then links
those symbols locally into one large object file that makes up libec.a
Fuzzing targets are linked against libec.a so that they can invoke ec
functionality while depending on outside libraries that need cstdlib.
When linking a particular object against cstdlib, to avoid conflicting
function declarations put the following before any includes from the
ec codebase:
#define __stdlib_compat(...)
The fuzzing targets are now linked using clang++, so that c++ libraries
and objects can be used as part of the fuzzers.
BRANCH=none
BUG=chromium:876582
TEST=make -j buildfuzztests &&
./build/host/host_command_fuzz/host_command_fuzz.exe
Change-Id: Ifdfdc6a51c6ef23b4e192b013ca993bf48a4411b
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1180401
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'include/common.h')
-rw-r--r-- | include/common.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/include/common.h b/include/common.h index dac0bf2f00..f6bf9b1308 100644 --- a/include/common.h +++ b/include/common.h @@ -215,6 +215,17 @@ enum ec_error_list { #define test_export_static static #endif +/* + * Mark functions that collide with stdlib so they can be hidden when linking + * against libraries that require stdlib. HIDE_EC_STDLIB should be defined + * before including common.h from code that links to cstdlib. + */ +#ifdef TEST_FUZZ +#define __stdlib_compat __attribute__((visibility("hidden"))) +#else /* TEST_FUZZ */ +#define __stdlib_compat +#endif /* TEST_FUZZ */ + /* find the most significant bit. Not defined in n == 0. */ #define __fls(n) (31 - __builtin_clz(n)) |