diff options
| author | Caveh Jalali <caveh@chromium.org> | 2020-06-26 18:12:55 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-29 03:55:45 +0000 |
| commit | ea103fe804e831443d4e192301084ce9112349a9 (patch) | |
| tree | 857e510d41f538439f505ce1a4d4d340403f4bd7 /driver | |
| parent | 9fe816a1c3a1286a6510b92503857ded5ae4b5fe (diff) | |
| download | chrome-ec-ea103fe804e831443d4e192301084ce9112349a9.tar.gz | |
ps8xxx: add helper function to access alternate I2C pages
this provides a helper function for computing the I2C page address of
alternate I2C pages available on the ps8xxx family of chips.
BRANCH=none
BUG=b:158857815,b:159289062
TEST=buildall passes
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Change-Id: I121ec9f2beaadf3e4e3c429d177fe38eb2976be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2271700
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/tcpm/ps8xxx.c | 6 | ||||
| -rw-r--r-- | driver/tcpm/ps8xxx.h | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/driver/tcpm/ps8xxx.c b/driver/tcpm/ps8xxx.c index 4126ed24a0..287e5f1467 100644 --- a/driver/tcpm/ps8xxx.c +++ b/driver/tcpm/ps8xxx.c @@ -283,8 +283,7 @@ static int ps8xxx_dci_disable(int port) int p1_addr; /* DCI registers are always accessible on PS8805 */ - p1_addr = tcpc_config[port].i2c_info.addr_flags - - (PS8751_I2C_ADDR1_FLAGS - PS8751_I2C_ADDR1_P1_FLAGS); + p1_addr = PS8751_P3_TO_P1_FLAGS(tcpc_config[port].i2c_info.addr_flags); return ps8xxx_addr_dci_disable(port, p1_addr, PS8805_P1_REG_MUX_USB_DCI_CFG); } @@ -309,8 +308,7 @@ static int ps8xxx_dci_disable(int port) PS8XXX_REG_I2C_DEBUGGING_ENABLE_ON); /* Disable Auto DCI */ - p1_addr = p3_addr - - (PS8751_I2C_ADDR1_FLAGS - PS8751_I2C_ADDR1_P1_FLAGS); + p1_addr = PS8751_P3_TO_P1_FLAGS(p3_addr); rv = ps8xxx_addr_dci_disable(port, p1_addr, PS8705_P1_REG_MUX_USB_DCI_CFG); diff --git a/driver/tcpm/ps8xxx.h b/driver/tcpm/ps8xxx.h index 9bd1cbd389..68d985fbf2 100644 --- a/driver/tcpm/ps8xxx.h +++ b/driver/tcpm/ps8xxx.h @@ -11,12 +11,14 @@ /* I2C interface */ #define PS8751_I2C_ADDR1_P1_FLAGS 0x09 -#define PS8751_I2C_ADDR1_P2_FLAGS 0x0a -#define PS8751_I2C_ADDR1_FLAGS 0x0B +#define PS8751_I2C_ADDR1_P2_FLAGS 0x0A +#define PS8751_I2C_ADDR1_FLAGS 0x0B /* P3 */ #define PS8751_I2C_ADDR2_FLAGS 0x1B #define PS8751_I2C_ADDR3_FLAGS 0x2B #define PS8751_I2C_ADDR4_FLAGS 0x4B +#define PS8751_P3_TO_P1_FLAGS(p3_flags) ((p3_flags) - 2) + /* Minimum Delay for reset assertion */ #define PS8XXX_RESET_DELAY_MS 1 |