diff options
| author | Denis Brockus <dbrockus@chromium.org> | 2019-06-25 12:44:16 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-23 00:12:30 +0000 |
| commit | ee8d481a027b78796ce30a48224e043fdf5f7491 (patch) | |
| tree | be23edd0a16a6548302c45da04740ba19809a40e /driver/ioexpander_pca9534.h | |
| parent | 220205c8480433cb72f7c738ba141d5afa6d1968 (diff) | |
| download | chrome-ec-ee8d481a027b78796ce30a48224e043fdf5f7491.tar.gz | |
Use 7bit I2C/SPI slave addresses in EC
Opt for 7bit slave addresses in EC code. If 8bit is
expected by a driver, make it local and show this in
the naming.
Use __7b, __7bf and __8b as name extensions for i2c/spi
addresses used in the EC codebase. __7b indicates a
7bit address by itself. __7bf indicates a 7bit address
with optional flags attached. __8b indicates a 8bit
address by itself.
Allow space for 10bit addresses, even though this is
not currently being used by any of our attached
devices.
These extensions are for verification purposes only and
will be removed in the last pass of this ticket. I want
to make sure the variable names reflect the type to help
eliminate future 7/8/7-flags confusion.
BUG=chromium:971296
BRANCH=none
TEST=make buildall -j
Change-Id: I2fc3d1b52ce76184492b2aaff3060f486ca45f45
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1699893
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1767525
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Tested-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'driver/ioexpander_pca9534.h')
| -rw-r--r-- | driver/ioexpander_pca9534.h | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/driver/ioexpander_pca9534.h b/driver/ioexpander_pca9534.h index d8cf896a49..e6848e21a2 100644 --- a/driver/ioexpander_pca9534.h +++ b/driver/ioexpander_pca9534.h @@ -26,7 +26,8 @@ * * @return EC_SUCCESS, or EC_ERROR_* on error. */ -int pca9534_get_level(int port, int addr, int pin, int *level); +int pca9534_get_level__7bf(const int port, const uint16_t addr__7bf, + int pin, int *level); /* * Set output level. This function has no effect if the pin is @@ -39,7 +40,8 @@ int pca9534_get_level(int port, int addr, int pin, int *level); * * @return EC_SUCCESS, or EC_ERROR_* on error. */ -int pca9534_set_level(int port, int addr, int pin, int level); +int pca9534_set_level__7bf(const int port, const uint16_t addr__7bf, + int pin, int level); /* * Config a pin as input or output. @@ -51,6 +53,7 @@ int pca9534_set_level(int port, int addr, int pin, int level); * * @return EC_SUCCESS, or EC_ERROR_* on error. */ -int pca9534_config_pin(int port, int addr, int pin, int is_input); +int pca9534_config_pin__7bf(const int port, const uint16_t addr__7bf, + int pin, int is_input); #endif /* __CROS_EC_IOEXPANDER_PCA9534_H */ |