diff options
author | Gwendal Grignou <gwendal@chromium.org> | 2015-08-25 18:22:24 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2015-08-29 00:04:15 -0700 |
commit | 7a2299163b7769b546db53c0dd225eee9e0a0df1 (patch) | |
tree | 6fed3596ec94354b08d85ce2b65621aedd2794e2 /driver/accelgyro_lsm6ds0.c | |
parent | 252dce9bd3d70b09e33aba17580ad11d1203ee73 (diff) | |
download | chrome-ec-7a2299163b7769b546db53c0dd225eee9e0a0df1.tar.gz |
driver: change get_ interface.
Simplify sensor get_data_rate, get_range and get_resolution.
Error code was not checked and these functions as currently implemented
have no reason to fail.
BRANCH=ryu,samus,cyan,strago
BUG=chromium:513458
TEST=Check on ryu, compile
Change-Id: I40dca41cee29a19f65b2f84d434b4c19eb6cbf3c
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/295635
Reviewed-by: Sheng-liang Song <ssl@chromium.org>
Diffstat (limited to 'driver/accelgyro_lsm6ds0.c')
-rw-r--r-- | driver/accelgyro_lsm6ds0.c | 23 |
1 files changed, 8 insertions, 15 deletions
diff --git a/driver/accelgyro_lsm6ds0.c b/driver/accelgyro_lsm6ds0.c index 9aa6644670..dee3e7d622 100644 --- a/driver/accelgyro_lsm6ds0.c +++ b/driver/accelgyro_lsm6ds0.c @@ -200,13 +200,11 @@ accel_cleanup: return ret; } -static int get_range(const struct motion_sensor_t *s, - int *range) +static int get_range(const struct motion_sensor_t *s) { struct lsm6ds0_data *data = s->drv_data; - *range = data->base.range; - return EC_SUCCESS; + return data->base.range; } static int set_resolution(const struct motion_sensor_t *s, @@ -217,11 +215,9 @@ static int set_resolution(const struct motion_sensor_t *s, return EC_SUCCESS; } -static int get_resolution(const struct motion_sensor_t *s, - int *res) +static int get_resolution(const struct motion_sensor_t *s) { - *res = LSM6DS0_RESOLUTION; - return EC_SUCCESS; + return LSM6DS0_RESOLUTION; } static int set_data_rate(const struct motion_sensor_t *s, @@ -278,13 +274,11 @@ accel_cleanup: return ret; } -static int get_data_rate(const struct motion_sensor_t *s, - int *rate) +static int get_data_rate(const struct motion_sensor_t *s) { struct lsm6ds0_data *data = s->drv_data; - *rate = data->base.odr; - return EC_SUCCESS; + return data->base.odr; } static int set_offset(const struct motion_sensor_t *s, @@ -381,7 +375,7 @@ static int read(const struct motion_sensor_t *s, vector_3_t v) rotate(v, *s->rot_standard_ref, v); /* apply offset in the device coordinates */ - get_range(s, &range); + range = get_range(s); for (i = X; i <= Z; i++) v[i] += (data->offset[i] << 5) / range; @@ -454,8 +448,7 @@ static int init(const struct motion_sensor_t *s) } CPRINTF("[%T %s: MS Done Init type:0x%X range:%d odr:%d]\n", - s->name, s->type, s->runtime_config.range, - s->runtime_config.odr); + s->name, s->type, get_range(s), get_data_rate(s)); return ret; } |