diff options
| author | Vadim Sukhomlinov <sukhomlinov@google.com> | 2021-11-10 10:57:30 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-11-10 19:48:58 +0000 |
| commit | bd99fd9293a84aa924ba944415752f432e1ca9ae (patch) | |
| tree | 28e6ee56da7e262c5ca94aad8f7fc8cc7697731e /core/cortex-m0/curve25519/mpy121666.S | |
| parent | ce47708581eba18f391e51d09f63a25aee5cc19b (diff) | |
| download | chrome-ec-bd99fd9293a84aa924ba944415752f432e1ca9ae.tar.gz | |
cr50: usb_pdu_valid should check if crypto is allowed before check
In unusual case when FIPS test fails, fw_upgrade will fail too as
usb_pdu_valid() didn't check for failure and incorrectly assumed that
digest of data doesn't match. Making check conditional on success of
hash computation.
BUG=b:205836895
TEST=make BOARD=cr50 CRYPTO_TEST=1;
fips sha
fips test in CCD
attempt to firmware upgrade using gsctool
Signed-off-by: Vadim Sukhomlinov <sukhomlinov@google.com>
Change-Id: Iea38f82a46fb00ad0ed543cd9b4b950a6b1c102e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3272287
Reviewed-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Tested-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Commit-Queue: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Diffstat (limited to 'core/cortex-m0/curve25519/mpy121666.S')
0 files changed, 0 insertions, 0 deletions