diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-03-21 18:06:34 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-03-24 22:24:07 +0000 |
| commit | 6f24b75a15d5a00b2a5b06b0b4c1deb912d6dd98 (patch) | |
| tree | fcac0205db6ec120d2cf04145a423e54add7e2cb /common | |
| parent | fabb15c70628c44a790149ef3402d77dd84f3293 (diff) | |
| download | chrome-ec-6f24b75a15d5a00b2a5b06b0b4c1deb912d6dd98.tar.gz | |
Cr50: cleanup: Clarify a few comments
BUG=none
BRANCH=none
TEST=make buildall; try on Cr50
No code changes, just comments.
Change-Id: I3eccccb024b4a319920a8252cd7d5d3829bf21da
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/334820
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/tpm_registers.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/common/tpm_registers.c b/common/tpm_registers.c index 68a7bff4cb..fa32180849 100644 --- a/common/tpm_registers.c +++ b/common/tpm_registers.c @@ -324,6 +324,9 @@ static void fifo_reg_write(const uint8_t *data, uint32_t data_size) tpm_.regs.sts &= ~expect; } +/* TODO: data_size is between 1 and 64, but is not trustworthy! Don't write + * past the end of any actual registers if data_size is larger than the spec + * allows. */ void tpm_register_put(uint32_t regaddr, const uint8_t *data, uint32_t data_size) { uint32_t i; @@ -368,6 +371,10 @@ void fifo_reg_read(uint8_t *dest, uint32_t data_size) tpm_.regs.sts &= ~(data_avail | command_ready); } + +/* TODO: data_size is between 1 and 64, but is not trustworthy! We must return + * that many bytes, but not leak any secrets if data_size is larger than + * it should be. Return 0x00 or 0xff or whatever the spec says instead. */ void tpm_register_get(uint32_t regaddr, uint8_t *dest, uint32_t data_size) { CPRINTF("%s(0x%06x, %d)", __func__, regaddr, data_size); |