summaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorRandall Spangler <rspangler@chromium.org>2012-09-10 15:15:06 -0700
committerGerrit <chrome-bot@google.com>2012-09-11 09:46:16 -0700
commitb0891c30e0d5d0086b9d01e87ded99d79195d6ad (patch)
treedd3baec2161f88e5810b665675d866dcade64d73 /common
parent774d047d5ee363c565cf58561c2d92c871eb87cf (diff)
downloadchrome-ec-b0891c30e0d5d0086b9d01e87ded99d79195d6ad.tar.gz
Cleanup: move lightbar command enum into ec_commands.h
Previously this was in lightbar.h. ec_commands.h should not require other header files. Also make brightness local variable static, so it won't leak outside lightbar module. This is simply code cleanup; values themselves have not changed. BUG=none TEST=if it builds, it's fine BRANCH=none (not required in link branch since it's just cleanup) Change-Id: I5722fb677fcec99e0826e3dfc0b22033781b576f Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/32815 Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Yung-Chieh Lo <yjlou@chromium.org>
Diffstat (limited to 'common')
-rw-r--r--common/lightbar.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/lightbar.c b/common/lightbar.c
index eb9c0014a8..cfb292249d 100644
--- a/common/lightbar.c
+++ b/common/lightbar.c
@@ -113,7 +113,7 @@ static inline uint8_t scale_abs(int val, int max)
}
/* It will often be simpler to provide an overall brightness control. */
-int brightness = 0x80;
+static int brightness = 0x80;
/* So that we can make brightness changes happen instantly, we need to track
* the current values. The values in the controllers aren't very helpful. */