diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-10-25 10:26:16 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-10-31 18:43:39 +0000 |
| commit | 2dc1418ccdad1b06f686cddc717e02bcb80ff648 (patch) | |
| tree | 3feb80ddd776a1c641fbc37b111cf3a06edceb3d /common/util.c | |
| parent | d16a246ea9c7d5982d4eb932c09310146ab3463e (diff) | |
| download | chrome-ec-2dc1418ccdad1b06f686cddc717e02bcb80ff648.tar.gz | |
cleanup: Assorted TODO comments
Remove comments if no longer applicable, or assign bug numbers if they
still are. Tidy some debug output. No code changes other than the
debug output.
BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all platforms, pass unit tests
Change-Id: I2277e73fbf8cc93f3b1b35ee115e0f2f52eb8cf9
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/175215
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'common/util.c')
| -rw-r--r-- | common/util.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/common/util.c b/common/util.c index f120cdad24..46e11372ed 100644 --- a/common/util.c +++ b/common/util.c @@ -171,7 +171,10 @@ int memcmp(const void *s1, const void *s2, int len) void *memcpy(void *dest, const void *src, int len) { - /* TODO: optimized version using LDM/STM would be much faster */ + /* + * TODO(crosbug.com/p/23720): if src/dest are aligned, copy a word at a + * time instead. + */ char *d = (char *)dest; const char *s = (const char *)src; while (len > 0) { @@ -184,7 +187,10 @@ void *memcpy(void *dest, const void *src, int len) void *memset(void *dest, int c, int len) { - /* TODO: optimized version using STM would be much faster */ + /* + * TODO(crosbug.com/p/23720): if dest is aligned, copy a word at a time + * instead. + */ char *d = (char *)dest; while (len > 0) { *(d++) = c; @@ -205,7 +211,10 @@ void *memmove(void *dest, const void *src, int len) /* Copy from end, so we don't overwrite the source */ char *d = (char *)dest + len; const char *s = (const char *)src + len; - /* TODO: optimized version using LDM/STM would be much faster */ + /* + * TODO(crosbug.com/p/23720): if src/dest are aligned, copy a + * word at a time instead. + */ while (len > 0) { *(--d) = *(--s); len--; |