diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-06-29 13:14:43 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-07-10 22:21:58 +0000 |
| commit | 23ea3fbd4a6e52b8a54f4278bbed8975af34cca7 (patch) | |
| tree | 84b8b0ee67f7fdbb9d9ad44695ed7659439c7c06 /common/usbc/usbc_task.c | |
| parent | 0f713b36be38449cddea2196d1a135d7bdcfb82a (diff) | |
| download | chrome-ec-23ea3fbd4a6e52b8a54f4278bbed8975af34cca7.tar.gz | |
tcpmv2: perform partner reset on startup, remove BBRAM
- Reset the port partner by applying CC Open on both CC lines
- Reuse the existing error recovery state to apply CC values
- Extend error recovery timer to 240 msec to account for us being able
to source Vconn
- Since we always reset on startup, we don't need to store previous
contracts in BBRAM.
BRANCH=none
BUG=b:159495742,b:158802939
TEST=see that we apply CC Open upon reset
TEST=see that we do not get a fault on Trembyle went setting CC open
TEST=apple 3-1 dongle with display port and power on Puff will come back
with power and display after a `reboot` EC command (which will trigger
the ErrorRecovery brownout path)
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: Iaac09d62e4a31557492cebb354d3a34371c1e9bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2271002
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'common/usbc/usbc_task.c')
| -rw-r--r-- | common/usbc/usbc_task.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/common/usbc/usbc_task.c b/common/usbc/usbc_task.c index 7bd0cdddd8..5c14903619 100644 --- a/common/usbc/usbc_task.c +++ b/common/usbc/usbc_task.c @@ -157,18 +157,6 @@ test_only_restart: if (IS_ENABLED(CONFIG_USB_TYPEC_SM)) tc_state_init(port); - if (IS_ENABLED(CONFIG_USBC_PPC) && - port < board_get_usb_pd_port_count()) { - /* - * Wait to initialize the PPC after tc_state_init(), which sets - * the correct Rd values in the TCPC; otherwise the TCPC might - * not be pulling the CC lines down when the PPC connects the - * CC lines from the USB connector to the TCPC cause the source - * to drop Vbus causing a brown out. - */ - ppc_init(port); - } - /* * Since most boards configure the TCPC interrupt as edge * and it is possible that the interrupt line was asserted between init |