diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /common/spi_nor.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/spi_nor.c')
| -rw-r--r-- | common/spi_nor.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/common/spi_nor.c b/common/spi_nor.c index 28ca4899c2..9c0bec9523 100644 --- a/common/spi_nor.c +++ b/common/spi_nor.c @@ -786,8 +786,7 @@ static int command_spi_nor_info(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(spinorinfo, command_spi_nor_info, "[device]", - "Report Serial NOR Flash device information", - NULL); + "Report Serial NOR Flash device information"); #endif /* CONFIG_CMD_SPI_NOR */ #ifdef CONFIG_CMD_SPI_NOR @@ -817,8 +816,7 @@ static int command_spi_nor_erase(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(spinorerase, command_spi_nor_erase, "device [offset] [size]", - "Erase flash", - NULL); + "Erase flash"); #endif /* CONFIG_CMD_SPI_NOR */ #ifdef CONFIG_CMD_SPI_NOR @@ -869,8 +867,7 @@ static int command_spi_nor_write(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(spinorwrite, command_spi_nor_write, "device [offset] [size]", - "Write pattern to flash", - NULL); + "Write pattern to flash"); #endif /* CONFIG_CMD_SPI_NOR */ #ifdef CONFIG_CMD_SPI_NOR @@ -933,6 +930,5 @@ err_free: } DECLARE_CONSOLE_COMMAND(spinorread, command_spi_nor_read, "device [offset] [size]", - "Read flash", - NULL); + "Read flash"); #endif /* CONFIG_CMD_SPI_NOR */ |