diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /common/keyboard_8042.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/keyboard_8042.c')
| -rw-r--r-- | common/keyboard_8042.c | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/common/keyboard_8042.c b/common/keyboard_8042.c index b4b39008c3..931583ecfd 100644 --- a/common/keyboard_8042.c +++ b/common/keyboard_8042.c @@ -986,8 +986,7 @@ static int command_typematic(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(typematic, command_typematic, "[first] [inter]", - "Get/set typematic delays", - NULL); + "Get/set typematic delays"); static int command_codeset(int argc, char **argv) @@ -1010,8 +1009,7 @@ static int command_codeset(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(codeset, command_codeset, "[set]", - "Get/set keyboard codeset", - NULL); + "Get/set keyboard codeset"); static int command_controller_ram(int argc, char **argv) @@ -1033,8 +1031,7 @@ static int command_controller_ram(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(ctrlram, command_controller_ram, "index [value]", - "Get/set keyboard controller RAM", - NULL); + "Get/set keyboard controller RAM"); static int command_keyboard_log(int argc, char **argv) { @@ -1080,8 +1077,7 @@ static int command_keyboard_log(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(kblog, command_keyboard_log, "[on | off]", - "Print or toggle keyboard event log", - NULL); + "Print or toggle keyboard event log"); static int command_keyboard(int argc, char **argv) @@ -1100,8 +1096,7 @@ static int command_keyboard(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(kbd, command_keyboard, "[0 | 1]", - "Print or toggle keyboard info", - NULL); + "Print or toggle keyboard info"); static int command_8042_internal(int argc, char **argv) @@ -1187,8 +1182,7 @@ static int command_8042(int argc, char **argv) DECLARE_CONSOLE_COMMAND(8042, command_8042, "[internal | typematic | codeset | ctrlram |" " kblog | kbd]", - "Print 8042 state in one place", - NULL); + "Print 8042 state in one place"); #endif |