summaryrefslogtreecommitdiff
path: root/common/host_command_pd.c
diff options
context:
space:
mode:
authorAlec Berg <alecaberg@chromium.org>2014-08-04 15:09:36 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-08-06 04:36:44 +0000
commit02d313201ffe48dd4157aa30ce36d3f4e08cb383 (patch)
tree3596176a462a74714e6de9494c5ede27e608a9c5 /common/host_command_pd.c
parente1557b0f42a64eb6c973d43a34158888905e33b9 (diff)
downloadchrome-ec-02d313201ffe48dd4157aa30ce36d3f4e08cb383.tar.gz
samus_pd: remove dead code around allowing PD negotiation
Remove code for preventing PD negotiation until the battery is at some minimum SOC. This was originally necessary because transitioning voltages would cause the source voltage to go briefly to 0V, which would kill power to the system unless the battery was at some minimum level of charge. But, that isn't true anymore. It is safe to transition up or down in voltage and the source voltage should never drop to 0V. BUG=chrome-os-partner:29499 BRANCH=none TEST=make -j buildall. No need to do any more testing because this code has been disabled for a while. Change-Id: I8a3dca117f01f0f9c7d04b5d489e4a8588a89be6 Signed-off-by: Alec Berg <alecaberg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/211021 Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'common/host_command_pd.c')
-rw-r--r--common/host_command_pd.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/common/host_command_pd.c b/common/host_command_pd.c
index ed9f97a21e..2f27e00d3d 100644
--- a/common/host_command_pd.c
+++ b/common/host_command_pd.c
@@ -28,10 +28,6 @@ static void pd_exchange_status(void)
struct ec_response_pd_status pd_status;
int rv = 0, tries = 0;
- /*
- * TODO(crosbug.com/p/29499): Change sending state of charge to
- * remaining capacity for finer grained control.
- */
/* Send battery state of charge */
if (charge_get_flags() & CHARGE_FLAG_BATT_RESPONSIVE)
ec_status.batt_soc = charge_get_percent();