diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /chip/it83xx/i2c.c | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/it83xx/i2c.c')
| -rw-r--r-- | chip/it83xx/i2c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chip/it83xx/i2c.c b/chip/it83xx/i2c.c index a88599b380..56f805b9f6 100644 --- a/chip/it83xx/i2c.c +++ b/chip/it83xx/i2c.c @@ -292,7 +292,7 @@ static void i2c_pio_trans_data(int p, enum enhanced_i2c_transfer_direct direct, if (first_byte) { /* First byte must be slave address. */ IT83XX_I2C_DTR(p_ch) = - data | (direct == RX_DIRECT ? (1 << 0) : 0); + data | (direct == RX_DIRECT ? BIT(0) : 0); /* start or repeat start signal. */ IT83XX_I2C_CTR(p_ch) = E_START_ID; } else { @@ -457,7 +457,7 @@ static void enhanced_i2c_start(int p) */ IT83XX_I2C_TOR(p_ch) = I2C_CLK_LOW_TIMEOUT; /* bit1: Enable enhanced i2c module */ - IT83XX_I2C_CTR1(p_ch) = (1 << 1); + IT83XX_I2C_CTR1(p_ch) = BIT(1); } static int enhanced_i2c_tran_write(int p) |