summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorAseda Aboagye <aaboagye@google.com>2019-11-18 18:32:35 -0800
committerCommit Bot <commit-bot@chromium.org>2019-11-21 23:20:03 +0000
commit14e356b73ee9c40170c8c0042dd452ba83b5ead9 (patch)
tree8a115b2c0ea3cc5e31528d963a304ae04f3b4bec /builtin
parent073a512059c475b75f2e5b55ffa807c2f1762b6b (diff)
downloadchrome-ec-14e356b73ee9c40170c8c0042dd452ba83b5ead9.tar.gz
TCPMv1: Improve jitter based collision avoidance
For the holdoff timer, we were using the system timestamp as a source of adding jitter. However, it seems that there are certain cases that can cause a periodic collision with the jitter only varying by ~1-2ms. This leads to many repeated collisions until the jitter slides just out of the collision window. This commit changes the jitter calculation to use more of the bits that are changing to reduce the number of collisions. BUG=b:144676183, chromium:925618 BRANCH=hatch,atlas,nocturne,grunt,octopus,rammus,kukui TEST=Flash kohaku, plug some peripherals known for collisions, verify that if a collision is encountered, it's only encountered once (no cycles). TEST=Add debugging prints for the jitter, verify that the jitter is varied and appears non-deterministic. Change-Id: I6c27880551dd35b78993f7130d1ce4eb81aa10ef Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1922751 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions