diff options
| author | Wai-Hong Tam <waihong@google.com> | 2018-12-04 13:30:54 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-12-05 01:13:32 -0800 |
| commit | 5eb2d70128d9a41ff0b83362e6beec23b7dae3d9 (patch) | |
| tree | c7592c0ccf4c3ee9fb83fdc102e230fb8a2ca707 /board | |
| parent | 0034f8f365e647514e16c61031f661753089cf66 (diff) | |
| download | chrome-ec-5eb2d70128d9a41ff0b83362e6beec23b7dae3d9.tar.gz | |
cheza: Remove the TODO's of verifying the config values
Checked the resistor values. And some timing and power values are all
the same in other boards.
BRANCH=none
BUG=b:79163120
TEST=Flashed the EC and verified charging and sourcing.
Change-Id: I1574cf539ee36c80694d514f6bd47ccfd8b1660e
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1361681
Reviewed-by: Philip Chen <philipchen@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/cheza/board.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/board/cheza/board.h b/board/cheza/board.h index 4fce7868fe..dfdb6e92f4 100644 --- a/board/cheza/board.h +++ b/board/cheza/board.h @@ -86,7 +86,6 @@ #define CONFIG_CHARGER_PSYS_READ #define CONFIG_CHARGER_DISCHARGE_ON_AC -/* TODO(b/79163120): Use correct charger values, copied from Lux for rev-0 */ #define CONFIG_CHARGER_INPUT_CURRENT 512 #define CONFIG_CHARGER_MIN_BAT_PCT_FOR_POWER_ON 2 #define CONFIG_CHARGER_MIN_POWER_MW_FOR_POWER_ON 7500 @@ -135,17 +134,17 @@ #define CONFIG_CMD_ACCELS #define CONFIG_CMD_ACCEL_INFO -/* TODO(b/79163120): Use correct PD delay values, copied from Lux for rev-0 */ +/* PD */ #define PD_POWER_SUPPLY_TURN_ON_DELAY 30000 /* us */ #define PD_POWER_SUPPLY_TURN_OFF_DELAY 250000 /* us */ #define PD_VCONN_SWAP_DELAY 5000 /* us */ -/* TODO(b/79163120): Use correct PD power values, copied from Lux for rev-0 */ #define PD_OPERATING_POWER_MW 15000 -#define PD_MAX_POWER_MW 45000 +#define PD_MAX_POWER_MW ((PD_MAX_VOLTAGE_MV * PD_MAX_CURRENT_MA) / 1000) #define PD_MAX_CURRENT_MA 3000 #define PD_MAX_VOLTAGE_MV 20000 +/* Chipset */ #define CONFIG_CHIPSET_SDM845 #define CONFIG_CHIPSET_RESET_HOOK #define CONFIG_POWER_COMMON |