diff options
| author | Alec Berg <alecaberg@chromium.org> | 2015-06-09 11:06:47 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-06-09 21:30:39 +0000 |
| commit | 8f65ad20e3ad75365117830d50b96c0b5d941be7 (patch) | |
| tree | a4cec4b2107fb513c4e27f70e41ec35c1fcd2d6c /board | |
| parent | da1c425471e80450fbada8a4d7b9d4b8551467af (diff) | |
| download | chrome-ec-8f65ad20e3ad75365117830d50b96c0b5d941be7.tar.gz | |
glados: limit type-C voltage to 5V to increase charging reliability
Change charging workaround on glados to limit the max input voltage
to 5V. This provides more reliable charging by reducing the noise
on the i2c bus to battery and charger. Note, this limits charging
power to 15W.
BUG=none
BRANCH=none
TEST=load onto 3 different glados boards and charge for 10 minutes
with no i2c errors causing charging to stop.
Change-Id: I4d67b62a18cf40d645b132081a431f9ce187168b
Signed-off-by: Alec Berg <alecaberg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/276366
Reviewed-by: Shawn N <shawnn@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/glados/board.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/board/glados/board.h b/board/glados/board.h index 0a570f80ba..6b431c6d4a 100644 --- a/board/glados/board.h +++ b/board/glados/board.h @@ -21,8 +21,6 @@ #define CONFIG_CHARGER_SENSE_RESISTOR 10 #define CONFIG_CHARGER_SENSE_RESISTOR_AC 20 #define CONFIG_CHARGER_INPUT_CURRENT 512 -/* TODO: Remove this limit once boards can charge at higher than this */ -#define CONFIG_CHARGER_MAX_INPUT_CURRENT 1500 #define CONFIG_CHARGER_DISCHARGE_ON_AC #define CONFIG_CHIPSET_SKYLAKE @@ -129,7 +127,11 @@ extern const int supplier_priority[]; #define PD_OPERATING_POWER_MW 15000 #define PD_MAX_POWER_MW 60000 #define PD_MAX_CURRENT_MA 3000 -#define PD_MAX_VOLTAGE_MV 20000 +/* + * TODO: max voltage should be 20V, but this causes excessive i2c noise + * on battery bus on proto0, which leads to inconsistent charging. + */ +#define PD_MAX_VOLTAGE_MV 5000 /* Discharge battery when on AC power for factory test. */ int board_discharge_on_ac(int enable); |