diff options
| author | Nicolas Boichat <drinkcat@chromium.org> | 2019-06-17 13:08:06 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-20 05:52:11 +0000 |
| commit | b16b36b94989a0d8e0f2268099f91094668c70f9 (patch) | |
| tree | ce9f912e6dbb0ed05cfb958f21e1ff67a7898292 /board | |
| parent | bbe3abd8dbee0a91b5bfad214821768610b10371 (diff) | |
| download | chrome-ec-b16b36b94989a0d8e0f2268099f91094668c70f9.tar.gz | |
ec: Remove extraneous new line as the end of CPRINTS strings
CPRINTS already prints a new line, no need to add another one.
Spotted during boot on kukui, and then realized there are many
more instances:
""
[3.689239 Module 7 is not supported for clock disable
]
""
BRANCH=none
BUG=none
TEST=make buildall -j
TEST=`git grep CPRINTS | grep "\\\\n\""` shows nothing of
interest.
Change-Id: I4d2bbbc65a91fa56c6e6115aa5c353bfd2b384a1
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660519
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/cr50/wp.c | 4 | ||||
| -rw-r--r-- | board/flapjack/board.c | 2 | ||||
| -rw-r--r-- | board/nami/battery.c | 2 | ||||
| -rw-r--r-- | board/pdeval-stm32f072/usb_pd_policy.c | 4 | ||||
| -rw-r--r-- | board/samus_pd/board.c | 2 |
5 files changed, 7 insertions, 7 deletions
diff --git a/board/cr50/wp.c b/board/cr50/wp.c index 0e2a4020af..c90615b349 100644 --- a/board/cr50/wp.c +++ b/board/cr50/wp.c @@ -412,7 +412,7 @@ static int lock_enforced(const struct RollbackSpaceFwmp *fwmp) /* Let's verify that the FWMP structure makes sense. */ if (fwmp->struct_size != sizeof(*fwmp)) { - CPRINTS("%s: fwmp size mismatch (%d)\n", __func__, + CPRINTS("%s: fwmp size mismatch (%d)", __func__, fwmp->struct_size); return 1; } @@ -420,7 +420,7 @@ static int lock_enforced(const struct RollbackSpaceFwmp *fwmp) crc = crc8(&fwmp->struct_version, sizeof(struct RollbackSpaceFwmp) - offsetof(struct RollbackSpaceFwmp, struct_version)); if (fwmp->crc != crc) { - CPRINTS("%s: fwmp crc mismatch\n", __func__); + CPRINTS("%s: fwmp crc mismatch", __func__); return 1; } diff --git a/board/flapjack/board.c b/board/flapjack/board.c index 31be3b4beb..5549e7b97e 100644 --- a/board/flapjack/board.c +++ b/board/flapjack/board.c @@ -145,7 +145,7 @@ static void board_setup_panel(void) rv |= i2c_write8(I2C_PORT_CHARGER, RT946X_ADDR, MT6370_BACKLIGHT_BLPWM, 0xac); if (rv) - CPRINTS("Board setup panel failed\n"); + CPRINTS("Board setup panel failed"); } static enum panel_id board_get_panel_id(void) diff --git a/board/nami/battery.c b/board/nami/battery.c index 19c377371a..6b4a4a9119 100644 --- a/board/nami/battery.c +++ b/board/nami/battery.c @@ -354,7 +354,7 @@ static int battery_check_disconnect(void) if (fuel_gauge == GAUGE_TYPE_UNKNOWN) { fuel_gauge = get_gauge_ic(); - CPRINTS("fuel_gauge=%d\n", fuel_gauge); + CPRINTS("fuel_gauge=%d", fuel_gauge); } switch (fuel_gauge) { diff --git a/board/pdeval-stm32f072/usb_pd_policy.c b/board/pdeval-stm32f072/usb_pd_policy.c index ba899f5efb..86062725fe 100644 --- a/board/pdeval-stm32f072/usb_pd_policy.c +++ b/board/pdeval-stm32f072/usb_pd_policy.c @@ -301,7 +301,7 @@ static int svdm_dp_config(int port, uint32_t *payload) mux_state |= MUX_POLARITY_INVERTED; #endif - CPRINTS("pin_mode = %d\n", pin_mode); + CPRINTS("pin_mode = %d", pin_mode); if (!pin_mode) return 0; @@ -348,7 +348,7 @@ static int svdm_dp_attention(int port, uint32_t *payload) int lvl = PD_VDO_DPSTS_HPD_LVL(payload[1]); int irq = PD_VDO_DPSTS_HPD_IRQ(payload[1]); - CPRINTS("Attention: 0x%x\n", payload[1]); + CPRINTS("Attention: 0x%x", payload[1]); anx7447_tcpc_update_hpd_status(port, lvl, irq); #endif dp_status[port] = payload[1]; diff --git a/board/samus_pd/board.c b/board/samus_pd/board.c index c49844c370..772ee2cb3f 100644 --- a/board/samus_pd/board.c +++ b/board/samus_pd/board.c @@ -338,7 +338,7 @@ int board_set_active_charge_port(int charge_port) gpio_set_level(GPIO_USB_C1_CHARGE_EN_L, 1); charge_state = PD_CHARGE_NONE; pd_status.active_charge_port = charge_port; - CPRINTS("Chg: None\n"); + CPRINTS("Chg: None"); return EC_SUCCESS; } |