summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorJett Rink <jettrink@chromium.org>2018-08-17 13:34:43 -0600
committerchrome-bot <chrome-bot@chromium.org>2018-09-07 18:36:37 -0700
commit7fafaf999ff6d3b3565278a77fdba0a9ee1e26fe (patch)
tree0cedfd885b89c043e01fdc2bf129c5dd7f80e34d /board
parent7fdbe282d79bcb23f9507b3a128998e44285b451 (diff)
downloadchrome-ec-7fafaf999ff6d3b3565278a77fdba0a9ee1e26fe.tar.gz
octopus: use higher priority TCPC interrupt tasks
See go/usb-pd-slow-response-time for more information BRANCH=none BUG=b:112088135 TEST=CL stack on fleex and bobba consistently meet PD timing spec Change-Id: I9eabf8de8d866f5a0af7d1daba5ab585b418d26c Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1185729 Reviewed-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'board')
-rw-r--r--board/bobba/board.c12
-rw-r--r--board/bobba/ec.tasklist4
-rw-r--r--board/fleex/board.c12
-rw-r--r--board/fleex/ec.tasklist4
-rw-r--r--board/meep/board.c12
-rw-r--r--board/meep/ec.tasklist4
-rw-r--r--board/phaser/board.c12
-rw-r--r--board/phaser/ec.tasklist4
-rw-r--r--board/yorp/board.c12
-rw-r--r--board/yorp/ec.tasklist4
10 files changed, 15 insertions, 65 deletions
diff --git a/board/bobba/board.c b/board/bobba/board.c
index 6125356343..ab51d2709f 100644
--- a/board/bobba/board.c
+++ b/board/bobba/board.c
@@ -44,18 +44,6 @@
#define CPRINTSUSB(format, args...) cprints(CC_USBCHARGE, format, ## args)
#define CPRINTFUSB(format, args...) cprintf(CC_USBCHARGE, format, ## args)
-static void tcpc_alert_event(enum gpio_signal signal)
-{
- if ((signal == GPIO_USB_C1_MUX_INT_ODL) &&
- !gpio_get_level(GPIO_USB_C1_PD_RST_ODL))
- return;
-
-#ifdef HAS_TASK_PDCMD
- /* Exchange status with TCPCs */
- host_command_pd_send_status(PD_CHARGE_NO_CHANGE);
-#endif
-}
-
static void ppc_interrupt(enum gpio_signal signal)
{
switch (signal) {
diff --git a/board/bobba/ec.tasklist b/board/bobba/ec.tasklist
index 6f719b4acc..c847aa4917 100644
--- a/board/bobba/ec.tasklist
+++ b/board/bobba/ec.tasklist
@@ -34,4 +34,6 @@
TASK_ALWAYS(POWERBTN, power_button_task, NULL, LARGER_TASK_STACK_SIZE) \
TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \
TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
- TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE)
+ TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C0, pd_interrupt_handler_task, 0, TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C1, pd_interrupt_handler_task, 1, TASK_STACK_SIZE)
diff --git a/board/fleex/board.c b/board/fleex/board.c
index 697d072f45..6cedd0cecc 100644
--- a/board/fleex/board.c
+++ b/board/fleex/board.c
@@ -49,18 +49,6 @@
#define USB_PD_PORT_ANX7447 0
#define USB_PD_PORT_PS8751 1
-static void tcpc_alert_event(enum gpio_signal signal)
-{
- if ((signal == GPIO_USB_C1_MUX_INT_ODL) &&
- !gpio_get_level(GPIO_USB_C1_PD_RST_ODL))
- return;
-
-#ifdef HAS_TASK_PDCMD
- /* Exchange status with TCPCs */
- host_command_pd_send_status(PD_CHARGE_NO_CHANGE);
-#endif
-}
-
static void ppc_interrupt(enum gpio_signal signal)
{
switch (signal) {
diff --git a/board/fleex/ec.tasklist b/board/fleex/ec.tasklist
index 6f719b4acc..c847aa4917 100644
--- a/board/fleex/ec.tasklist
+++ b/board/fleex/ec.tasklist
@@ -34,4 +34,6 @@
TASK_ALWAYS(POWERBTN, power_button_task, NULL, LARGER_TASK_STACK_SIZE) \
TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \
TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
- TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE)
+ TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C0, pd_interrupt_handler_task, 0, TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C1, pd_interrupt_handler_task, 1, TASK_STACK_SIZE)
diff --git a/board/meep/board.c b/board/meep/board.c
index 2f0f4a825e..a89154c126 100644
--- a/board/meep/board.c
+++ b/board/meep/board.c
@@ -50,18 +50,6 @@
#define USB_PD_PORT_ANX7447 0
#define USB_PD_PORT_PS8751 1
-static void tcpc_alert_event(enum gpio_signal signal)
-{
- if ((signal == GPIO_USB_C1_MUX_INT_ODL) &&
- !gpio_get_level(GPIO_USB_C1_PD_RST_ODL))
- return;
-
-#ifdef HAS_TASK_PDCMD
- /* Exchange status with TCPCs */
- host_command_pd_send_status(PD_CHARGE_NO_CHANGE);
-#endif
-}
-
static void ppc_interrupt(enum gpio_signal signal)
{
switch (signal) {
diff --git a/board/meep/ec.tasklist b/board/meep/ec.tasklist
index 6f719b4acc..c847aa4917 100644
--- a/board/meep/ec.tasklist
+++ b/board/meep/ec.tasklist
@@ -34,4 +34,6 @@
TASK_ALWAYS(POWERBTN, power_button_task, NULL, LARGER_TASK_STACK_SIZE) \
TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \
TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
- TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE)
+ TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C0, pd_interrupt_handler_task, 0, TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C1, pd_interrupt_handler_task, 1, TASK_STACK_SIZE)
diff --git a/board/phaser/board.c b/board/phaser/board.c
index e64e445674..4fc423c33b 100644
--- a/board/phaser/board.c
+++ b/board/phaser/board.c
@@ -34,18 +34,6 @@
static uint16_t sku_id;
-static void tcpc_alert_event(enum gpio_signal signal)
-{
- if ((signal == GPIO_USB_C1_MUX_INT_ODL) &&
- !gpio_get_level(GPIO_USB_C1_PD_RST_ODL))
- return;
-
-#ifdef HAS_TASK_PDCMD
- /* Exchange status with TCPCs */
- host_command_pd_send_status(PD_CHARGE_NO_CHANGE);
-#endif
-}
-
static void ppc_interrupt(enum gpio_signal signal)
{
switch (signal) {
diff --git a/board/phaser/ec.tasklist b/board/phaser/ec.tasklist
index 6f719b4acc..c847aa4917 100644
--- a/board/phaser/ec.tasklist
+++ b/board/phaser/ec.tasklist
@@ -34,4 +34,6 @@
TASK_ALWAYS(POWERBTN, power_button_task, NULL, LARGER_TASK_STACK_SIZE) \
TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \
TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
- TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE)
+ TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C0, pd_interrupt_handler_task, 0, TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C1, pd_interrupt_handler_task, 1, TASK_STACK_SIZE)
diff --git a/board/yorp/board.c b/board/yorp/board.c
index ffc80a923e..920bcf661b 100644
--- a/board/yorp/board.c
+++ b/board/yorp/board.c
@@ -45,18 +45,6 @@
#define CPRINTS(format, args...) cprints(CC_SYSTEM, format, ## args)
-static void tcpc_alert_event(enum gpio_signal signal)
-{
- if ((signal == GPIO_USB_C1_MUX_INT_ODL) &&
- !gpio_get_level(GPIO_USB_C1_PD_RST_ODL))
- return;
-
-#ifdef HAS_TASK_PDCMD
- /* Exchange status with TCPCs */
- host_command_pd_send_status(PD_CHARGE_NO_CHANGE);
-#endif
-}
-
static void ppc_interrupt(enum gpio_signal signal)
{
switch (signal) {
diff --git a/board/yorp/ec.tasklist b/board/yorp/ec.tasklist
index 6f719b4acc..c847aa4917 100644
--- a/board/yorp/ec.tasklist
+++ b/board/yorp/ec.tasklist
@@ -34,4 +34,6 @@
TASK_ALWAYS(POWERBTN, power_button_task, NULL, LARGER_TASK_STACK_SIZE) \
TASK_NOTEST(KEYSCAN, keyboard_scan_task, NULL, TASK_STACK_SIZE) \
TASK_ALWAYS(PD_C0, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
- TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE)
+ TASK_ALWAYS(PD_C1, pd_task, NULL, LARGER_TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C0, pd_interrupt_handler_task, 0, TASK_STACK_SIZE) \
+ TASK_ALWAYS(PD_INT_C1, pd_interrupt_handler_task, 1, TASK_STACK_SIZE)
View Lorry Controller Status