diff options
| author | Yilun Lin <yllin@google.com> | 2018-09-08 00:31:36 +0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-09-18 15:38:15 +0000 |
| commit | a38f7585f1bad5bdff3a344daf67815d75f68614 (patch) | |
| tree | 585a5f1d560e770e52196c298717a535da061660 /board/samus | |
| parent | d86563db5c3f31bddd5924d30a5d065f2f73b6dc (diff) | |
| download | chrome-ec-a38f7585f1bad5bdff3a344daf67815d75f68614.tar.gz | |
type: Rename matrix_3x3_t to mat33_fp_t
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I51d88d44252184e4b7b3564236833b0b892edc39
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215449
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1230991
Reviewed-by: Martin Roth <martinroth@chromium.org>
Commit-Queue: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>
Diffstat (limited to 'board/samus')
| -rw-r--r-- | board/samus/board.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/samus/board.c b/board/samus/board.c index 646d8ded9a..b8f66ca101 100644 --- a/board/samus/board.c +++ b/board/samus/board.c @@ -299,13 +299,13 @@ struct lsm6ds0_data g_saved_data[2]; /* Four Motion sensors */ /* Matrix to rotate accelrator into standard reference frame */ -const matrix_3x3_t base_standard_ref = { +const mat33_fp_t base_standard_ref = { {FLOAT_TO_FP(-1), 0, 0}, { 0, FLOAT_TO_FP(-1), 0}, { 0, 0, FLOAT_TO_FP(-1)} }; -const matrix_3x3_t lid_standard_ref = { +const mat33_fp_t lid_standard_ref = { { 0, FLOAT_TO_FP(1), 0}, {FLOAT_TO_FP(-1), 0, 0}, { 0, 0, FLOAT_TO_FP(-1)} |