diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /board/plankton | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'board/plankton')
| -rw-r--r-- | board/plankton/board.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/board/plankton/board.c b/board/plankton/board.c index 8f56422ba1..5bc6b776a3 100644 --- a/board/plankton/board.c +++ b/board/plankton/board.c @@ -586,8 +586,7 @@ static int cmd_usbc_action(int argc, char *argv[]) } DECLARE_CONSOLE_COMMAND(usbc_action, cmd_usbc_action, "<5v|12v|20v|ccd|dev|usb|dp|flip|pol0|pol1|drp>", - "Set Plankton type-C port state", - NULL); + "Set Plankton type-C port state"); int board_in_hub_mode(void) { @@ -628,7 +627,7 @@ static int cmd_usb_hub_reset(int argc, char *argv[]) return board_usb_hub_reset(); } DECLARE_CONSOLE_COMMAND(hub_reset, cmd_usb_hub_reset, - NULL, "Reset USB hub", NULL); + NULL, "Reset USB hub"); static void board_usb_hub_reset_no_return(void) { @@ -771,7 +770,7 @@ static int cmd_fake_disconnect(int argc, char *argv[]) return EC_SUCCESS; } DECLARE_CONSOLE_COMMAND(fakedisconnect, cmd_fake_disconnect, - "<delay_ms> <duration_ms>", NULL, NULL); + "<delay_ms> <duration_ms>", NULL); static void trigger_dfu_release(void) { @@ -789,4 +788,4 @@ static int cmd_trigger_dfu(int argc, char *argv[]) hook_call_deferred(&trigger_dfu_release_data, 1500 * MSEC); return EC_SUCCESS; } -DECLARE_CONSOLE_COMMAND(dfu, cmd_trigger_dfu, NULL, NULL, NULL); +DECLARE_CONSOLE_COMMAND(dfu, cmd_trigger_dfu, NULL, NULL); |