diff options
| author | Jett Rink <jettrink@chromium.org> | 2018-03-05 10:46:06 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-03-06 09:59:19 -0800 |
| commit | 9ea3cbecb8d3fca58baf4aff8d7e97480fe25860 (patch) | |
| tree | 8beda6b42d6854631f5d5bad0216aca1b775f6f3 /board/npcx7_evb/board.h | |
| parent | 3b10e08bc341367f19de19946cbd21c36b4d95be (diff) | |
| download | chrome-ec-9ea3cbecb8d3fca58baf4aff8d7e97480fe25860.tar.gz | |
npcx: Conforming CONFIG_UART_HOST define to match intention
The CONFIG_UART_HOST is supposed to be defined to the index of the UART we
want to use. It is not supposed to be defined as a boolean. Updated npcx
and all incorrect uses.
BRANCH=none
BUG=none
TEST=Added the following diff to ensure that everything still built:
diff --git a/chip/npcx/lpc.c b/chip/npcx/lpc.c
index 446baa842..826233744 100644
--- a/chip/npcx/lpc.c
+++ b/chip/npcx/lpc.c
@@ -897,6 +897,9 @@ static void lpc_init(void)
/* Initialize Hardware for UART Host */
#ifdef CONFIG_UART_HOST
+#if !CONFIG_UART_HOST
+#error "Fix me"
+#endif
/* Init COMx LPC UART */
/* FMCLK have to using 50MHz */
NPCX_DEVALT(0xB) = 0xFF;
Change-Id: Ia46c7cb86c6040a5c75dddf23d5ccd8e33210581
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/949308
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'board/npcx7_evb/board.h')
| -rw-r--r-- | board/npcx7_evb/board.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/board/npcx7_evb/board.h b/board/npcx7_evb/board.h index adff4a9cd7..4f9c5ecf61 100644 --- a/board/npcx7_evb/board.h +++ b/board/npcx7_evb/board.h @@ -52,9 +52,6 @@ #define I2C_PORT_MASTER NPCX_I2C_PORT0_0 #define I2C_PORT_HOST 0 -/* LPC UART */ -#define CONFIG_UART_HOST 0 - /* Fans for testing */ #define CONFIG_FANS 1 |