diff options
| author | Vijay Hiremath <vijay.p.hiremath@intel.com> | 2016-12-21 16:27:09 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-01-02 16:16:59 -0800 |
| commit | 66ea614158975f7db9c0eeb141bb54c935a4ed61 (patch) | |
| tree | 28e70e57d7ab806b0a6f17fbe040eb3482eca449 /board/kevin | |
| parent | 18bb7c7971f4cb7c8d705f34ecd2797ce4e51023 (diff) | |
| download | chrome-ec-66ea614158975f7db9c0eeb141bb54c935a4ed61.tar.gz | |
smart_battery: Cleanup smart battery & SB users code
BUG=chrome-os-partner:61173
BRANCH=none
TEST=Manually tested on Reef. Battery info works.
Change-Id: I6e867eee38885186f8e63a934f52e826f0cf72fd
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/422998
Commit-Ready: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Tested-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'board/kevin')
| -rw-r--r-- | board/kevin/battery.c | 20 |
1 files changed, 6 insertions, 14 deletions
diff --git a/board/kevin/battery.c b/board/kevin/battery.c index c1b2e09c67..50df1d0258 100644 --- a/board/kevin/battery.c +++ b/board/kevin/battery.c @@ -80,15 +80,12 @@ enum battery_disconnect_state battery_get_disconnect_state(void) if (extpower_is_present()) { /* Check if battery charging + discharging is disabled. */ - rv = sb_write(SB_MANUFACTURER_ACCESS, PARAM_OPERATION_STATUS); + rv = sb_read_mfgacc(PARAM_OPERATION_STATUS, + SB_ALT_MANUFACTURER_ACCESS, data, sizeof(data)); if (rv) return BATTERY_DISCONNECT_ERROR; - - rv = sb_read_string(I2C_PORT_BATTERY, BATTERY_ADDR, - SB_ALT_MANUFACTURER_ACCESS, data, 6); - - if (rv || (~data[3] & (BATTERY_DISCHARGING_DISABLED | - BATTERY_CHARGING_DISABLED))) { + if (~data[3] & (BATTERY_DISCHARGING_DISABLED | + BATTERY_CHARGING_DISABLED)) { not_disconnected = 1; return BATTERY_NOT_DISCONNECTED; } @@ -97,13 +94,8 @@ enum battery_disconnect_state battery_get_disconnect_state(void) * Battery is neither charging nor discharging. Verify that * we didn't enter this state due to a safety fault. */ - rv = sb_write(SB_MANUFACTURER_ACCESS, PARAM_SAFETY_STATUS); - if (rv) - return BATTERY_DISCONNECT_ERROR; - - rv = sb_read_string(I2C_PORT_BATTERY, BATTERY_ADDR, - SB_ALT_MANUFACTURER_ACCESS, data, 6); - + rv = sb_read_mfgacc(PARAM_SAFETY_STATUS, + SB_ALT_MANUFACTURER_ACCESS, data, sizeof(data)); if (rv || data[2] || data[3] || data[4] || data[5]) return BATTERY_DISCONNECT_ERROR; |