summaryrefslogtreecommitdiff
path: root/board/dingdong
diff options
context:
space:
mode:
authorTodd Broch <tbroch@chromium.org>2014-11-06 02:34:47 -0800
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-11-11 00:11:18 +0000
commit84681349f444a9596d38117b41e8a279bb52a856 (patch)
treee53c17bcb712f8a41521bd60c54dae994d28797c /board/dingdong
parent56d92341f39570ea0f3e3ae2600b9710f79b6c3c (diff)
downloadchrome-ec-84681349f444a9596d38117b41e8a279bb52a856.tar.gz
pd: Send proper OPOS for DP status & config.
Once a mode is entered object position (OPOS ... AKA alternate mode) field in the VDM header should always track that mode. CL fixes DP status & config messages which did not add the correct OPOS. In fixing I mapped to the UFPs function pd_alt_mode which for the DFP did require the addition of port parameter. Finally I cleaned up code to use this function throughout common policy layer where previously I'd just accessed the pe structure directly. BRANCH=samus_pd BUG=none TEST=manual, compiles, insert hoho/dingdong into samus and see OPOS=1 from samus for enter, dp_config, dp_status SVDMs Change-Id: I66448c3386be01bae58768632da216aff41a9a30 Signed-off-by: Todd Broch <tbroch@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/228130 Reviewed-by: Vincent Palatin <vpalatin@chromium.org> Reviewed-by: Alec Berg <alecaberg@chromium.org> Commit-Queue: Alec Berg <alecaberg@chromium.org>
Diffstat (limited to 'board/dingdong')
-rw-r--r--board/dingdong/usb_pd_policy.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/board/dingdong/usb_pd_policy.c b/board/dingdong/usb_pd_policy.c
index 1cd9a7a5f0..181bc5a17f 100644
--- a/board/dingdong/usb_pd_policy.c
+++ b/board/dingdong/usb_pd_policy.c
@@ -215,7 +215,7 @@ static int svdm_enter_mode(int port, uint32_t *payload)
return 1;
}
-int pd_alt_mode(void)
+int pd_alt_mode(int port)
{
return alt_mode;
}