diff options
| author | Nick Sanders <nsanders@chromium.org> | 2018-08-27 11:42:26 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-08-29 16:09:31 -0700 |
| commit | c0ef4ac5ed138cca25ae1ff54dff58fafa344ded (patch) | |
| tree | 7276be857c52bbb201eba22c930f70605767cf30 /board/cr50/board.h | |
| parent | 475f67828ff64d5398616a3998f70178b96e2864 (diff) | |
| download | chrome-ec-c0ef4ac5ed138cca25ae1ff54dff58fafa344ded.tar.gz | |
cr50: Release EC Reset on power button release when SuzyQ detected.
It complements crrev.com/c/1137434 in the way EC Reset got released.
Instead of time-basis, it shall be released when the power button
is released.
The desired sequence of actions is:
0. (optional) Have a CR50 console and EC console connected to terminals.
1. Do a shutdown.
2. Press the power button and keep it pressed.
3. Plug a SuzyQ cable.
4. CR50 console shall be connected back, but not EC console.
5. Release the power button at any proper time, so that EC can restart.
To keep EC from resetting, do "ecrst true" in CR50 console right after
Step 4. It will invalidate Step 5.
BRANCH=cr50
BUG=b:37351386
TEST=manually on Duts, Bob (Chrombook) and Sion (chromebox).
(A) hard-reset
A-1. Binary Download + Hold power button => no delay in EC reset.
(B) Wake from hibernation
B-1. (EC console) hibernate
B-2. unplug all cables
B-3. hold "POWER BUTTON" + plug SuzyQ cable => no delay in EC reset.
(C) Power-on reset
C-1. "REFRESH" + "POWER BUTTON" + unplug power cable.
C-2. unplug SuzyQ cable
C-3. plug SuzyQ cable => no delay in EC reset.
(D) Power-on reset
D-1. "REFRESH" + "POWER BUTTON" + unplug power cable.
D-2. unplug SuzyQ cable
D-3. hold "POWER BUTTON" + plug SuzyQ cable. => EC reset gets held.
D-4. release "POWER BUTTON" ==> EC gets reset.
(E) Power-on reset + explicit "ec_rst true"
E-1. "REFRESH" + "POWER BUTTON" + unplug power cable.
E-2. unplug SuzyQ cable
E-3. hold "POWER BUTTON" + plug SuzyQ cable. => EC reset gets held.
E-4. (CR50 console) ecrst true
E-5. release "POWER BUTTON" ==> EC reset still gets held.
(F) Power-on reset + explicit "ec_rst false"
F-1. "REFRESH" + "POWER BUTTON" + unplug power cable.
F-2. unplug SuzyQ cable
F-3. hold "POWER BUTTON" + plug SuzyQ cable. => EC reset gets held.
F-4. (CR50 console) ecrst false => EC gets reset.
F-5. release "POWER BUTTON" ==> Nothing happens.
(common) Press "POWER BUTTON" again, and check CR50 doesn't have any
more "POWER BUTTON" release events.
Changes to be committed:
modified: board/cr50/board.c
modified: board/cr50/board.h
modified: board/cr50/power_button.c
modified: chip/g/rbox.c
Change-Id: Ic39c9ce7849fa3187e1d277320adf671f857d18d
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1192691
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'board/cr50/board.h')
| -rw-r--r-- | board/cr50/board.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/board/cr50/board.h b/board/cr50/board.h index 140f230d02..9e8da8acb1 100644 --- a/board/cr50/board.h +++ b/board/cr50/board.h @@ -269,6 +269,13 @@ int board_deep_sleep_allowed(void); void power_button_record(void); +/** + * Enable/disable power button release interrupt. + * + * @param enable Enable (!=0) or disable (==0) + */ +void power_button_release_enable_interrupt(int enable); + /* Functions needed by CCD config */ int board_battery_is_present(void); int board_fwmp_allows_unlock(void); |