summaryrefslogtreecommitdiff
path: root/board/cherry
diff options
context:
space:
mode:
authorSue Chen <sue.chen@quanta.corp-partner.google.com>2021-05-20 17:09:58 +0800
committerCommit Bot <commit-bot@chromium.org>2021-05-21 09:53:48 +0000
commit5bd7f9db4a51b995810894e72ebd218077a5059a (patch)
treed8b0ce2d72302e1c09069b7e56cdf13fdac0dd73 /board/cherry
parentaa1ab37b8f18a9438e420531c295141728ce0ae2 (diff)
downloadchrome-ec-5bd7f9db4a51b995810894e72ebd218077a5059a.tar.gz
Cherry: change gyro snesor to ICM-42607-P
Change base accelgyro driver to icm42607. BUG=b:187748640 BRANCH=none TEST=console "accelinfo on" and ectool motionsense show correctly. Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com> Change-Id: Ib53f72ae283a7bf5a6193dcf3b656121af94c66f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2909954 Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Diffstat (limited to 'board/cherry')
-rw-r--r--board/cherry/board.c47
-rw-r--r--board/cherry/board.h4
-rw-r--r--board/cherry/gpio.inc2
3 files changed, 33 insertions, 20 deletions
diff --git a/board/cherry/board.c b/board/cherry/board.c
index 4282aa99b3..e45699704a 100644
--- a/board/cherry/board.c
+++ b/board/cherry/board.c
@@ -15,7 +15,7 @@
#include "console.h"
#include "driver/accel_kionix.h"
#include "driver/accel_kx022.h"
-#include "driver/accelgyro_icm426xx.h"
+#include "driver/accelgyro_icm42607.h"
#include "driver/accelgyro_icm_common.h"
#include "driver/bc12/mt6360.h"
#include "driver/bc12/pi3usb9201.h"
@@ -65,9 +65,22 @@ DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT);
static struct mutex g_base_mutex;
static struct mutex g_lid_mutex;
-static struct icm_drv_data_t g_icm426xx_data;
+static struct icm_drv_data_t g_icm42607_data;
static struct kionix_accel_data g_kx022_data;
+/* Matrix to rotate accelrator into standard reference frame */
+static const mat33_fp_t base_standard_ref = {
+ { 0, FLOAT_TO_FP(1), 0},
+ { FLOAT_TO_FP(1), 0, 0},
+ { 0, 0, FLOAT_TO_FP(-1)}
+};
+
+static const mat33_fp_t lid_standard_ref = {
+ { FLOAT_TO_FP(-1), 0, 0},
+ { 0, FLOAT_TO_FP(-1), 0},
+ { 0, 0, FLOAT_TO_FP(1)}
+};
+
struct motion_sensor_t motion_sensors[] = {
/*
* Note: bmi160: supports accelerometer and gyro sensor
@@ -77,18 +90,18 @@ struct motion_sensor_t motion_sensors[] = {
[BASE_ACCEL] = {
.name = "Base Accel",
.active_mask = SENSOR_ACTIVE_S0_S3,
- .chip = MOTIONSENSE_CHIP_ICM426XX,
+ .chip = MOTIONSENSE_CHIP_ICM42607,
.type = MOTIONSENSE_TYPE_ACCEL,
.location = MOTIONSENSE_LOC_BASE,
- .drv = &icm426xx_drv,
+ .drv = &icm42607_drv,
.mutex = &g_base_mutex,
- .drv_data = &g_icm426xx_data,
+ .drv_data = &g_icm42607_data,
.port = I2C_PORT_ACCEL,
- .i2c_spi_addr_flags = ICM426XX_ADDR0_FLAGS,
+ .i2c_spi_addr_flags = ICM42607_ADDR0_FLAGS,
.default_range = 4, /* g, to meet CDD 7.3.1/C-1-4 reqs.*/
- .rot_standard_ref = NULL,
- .min_frequency = ICM426XX_ACCEL_MIN_FREQ,
- .max_frequency = ICM426XX_ACCEL_MAX_FREQ,
+ .rot_standard_ref = &base_standard_ref,
+ .min_frequency = ICM42607_ACCEL_MIN_FREQ,
+ .max_frequency = ICM42607_ACCEL_MAX_FREQ,
.config = {
/* EC use accel for angle detection */
[SENSOR_CONFIG_EC_S0] = {
@@ -103,18 +116,18 @@ struct motion_sensor_t motion_sensors[] = {
[BASE_GYRO] = {
.name = "Base Gyro",
.active_mask = SENSOR_ACTIVE_S0_S3,
- .chip = MOTIONSENSE_CHIP_ICM426XX,
+ .chip = MOTIONSENSE_CHIP_ICM42607,
.type = MOTIONSENSE_TYPE_GYRO,
.location = MOTIONSENSE_LOC_BASE,
- .drv = &icm426xx_drv,
+ .drv = &icm42607_drv,
.mutex = &g_base_mutex,
- .drv_data = &g_icm426xx_data,
+ .drv_data = &g_icm42607_data,
.port = I2C_PORT_ACCEL,
- .i2c_spi_addr_flags = ICM426XX_ADDR0_FLAGS,
+ .i2c_spi_addr_flags = ICM42607_ADDR0_FLAGS,
.default_range = 1000, /* dps */
- .rot_standard_ref = NULL,
- .min_frequency = ICM426XX_GYRO_MIN_FREQ,
- .max_frequency = ICM426XX_GYRO_MAX_FREQ,
+ .rot_standard_ref = &base_standard_ref,
+ .min_frequency = ICM42607_GYRO_MIN_FREQ,
+ .max_frequency = ICM42607_GYRO_MAX_FREQ,
},
[LID_ACCEL] = {
.name = "Lid Accel",
@@ -127,7 +140,7 @@ struct motion_sensor_t motion_sensors[] = {
.drv_data = &g_kx022_data,
.port = I2C_PORT_ACCEL,
.i2c_spi_addr_flags = KX022_ADDR1_FLAGS,
- .rot_standard_ref = NULL,
+ .rot_standard_ref = &lid_standard_ref,
.default_range = 2, /* g, enough for laptop. */
.min_frequency = KX022_ACCEL_MIN_FREQ,
.max_frequency = KX022_ACCEL_MAX_FREQ,
diff --git a/board/cherry/board.h b/board/cherry/board.h
index 32f2cefb48..e60f8104bb 100644
--- a/board/cherry/board.h
+++ b/board/cherry/board.h
@@ -45,8 +45,8 @@
#define GMR_TABLET_MODE_GPIO_L GPIO_TABLET_MODE_L
/* ICM426XX Base accel/gyro */
-#define CONFIG_ACCELGYRO_ICM426XX
-#define CONFIG_ACCELGYRO_ICM426XX_INT_EVENT \
+#define CONFIG_ACCELGYRO_ICM42607
+#define CONFIG_ACCELGYRO_ICM42607_INT_EVENT \
TASK_EVENT_MOTION_SENSOR_INTERRUPT(BASE_ACCEL)
/* KX022 Lid accel */
diff --git a/board/cherry/gpio.inc b/board/cherry/gpio.inc
index 111cacd271..5b07e5af56 100644
--- a/board/cherry/gpio.inc
+++ b/board/cherry/gpio.inc
@@ -30,7 +30,7 @@ GPIO_INT(PMIC_EC_PWRGD, PIN(F, 3),
/* Sensor Interrupts */
GPIO_INT(BASE_IMU_INT_L, PIN(M, 3), GPIO_INT_FALLING | GPIO_SEL_1P8V,
- icm426xx_interrupt)
+ icm42607_interrupt)
/* USB-C interrupts */
GPIO_INT(USB_C0_PPC_INT_ODL, PIN(D, 1), GPIO_INT_BOTH, ppc_interrupt)
GPIO_INT(USB_C0_BC12_INT_ODL,PIN(J, 4), GPIO_INT_FALLING, bc12_interrupt)