diff options
| author | Ting Shen <phoenixshen@google.com> | 2019-08-20 11:44:13 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-21 13:05:27 +0000 |
| commit | 0150cb3156125e47e5771c179094f6f7422ee36c (patch) | |
| tree | a2c16aeee26fb50387352f36ac73212bfbc609ab /baseboard | |
| parent | 986085f59b453894c59848842ca5faf15e97dd2d (diff) | |
| download | chrome-ec-0150cb3156125e47e5771c179094f6f7422ee36c.tar.gz | |
baseboard/kukui: remove incorrectly defined flags
The expected usage of baseboard.h is:
<in board.h>
#define VARIANT_KUKUI_SOMETHING
...
#include "baseboard.h"
If some VARIANT_KUKUI_* flag is also defined/removed in baseboard.h, it
will overwrite board's config. As a result, baseboard.h should not
define any of the VARIANT_* flags.
Move VARIANT_KUKUI_DP_MUX_GPIO into comment for document propose only.
BUG=b:139648560
TEST=verify both direction of dp works
BRANCH=master
Change-Id: I0b4f6afa07657ee4cd1495d302e026a99e770640
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1761752
Tested-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'baseboard')
| -rw-r--r-- | baseboard/kukui/baseboard.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/baseboard/kukui/baseboard.h b/baseboard/kukui/baseboard.h index b0313bf10c..1c1b8a980c 100644 --- a/baseboard/kukui/baseboard.h +++ b/baseboard/kukui/baseboard.h @@ -53,9 +53,11 @@ #endif /* VARIANT_KUKUI_CHARGER */ /* - * Board controls dp mux via gpio pins USB_C0_DP_OE_L and USB_C0_DP_POLARITY. + * Define this flag if board controls dp mux via gpio pins USB_C0_DP_OE_L and + * USB_C0_DP_POLARITY. + * + * #define VARIANT_KUKUI_DP_MUX_GPIO */ -#undef VARIANT_KUKUI_DP_MUX_GPIO /* Optional modules */ #define CONFIG_ADC |