diff options
| author | Denis Brockus <dbrockus@google.com> | 2020-07-17 08:53:39 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-07-17 22:57:28 +0000 |
| commit | 41fe226267e3a8c1cb61f9f25123eaea900b4971 (patch) | |
| tree | 2e60f764f0b61df6a0fab3ed3660234ecc01aa3c /baseboard/zork | |
| parent | 5dcfd3b5a5cffbe5e6a9ac9221f63d785a7a10af (diff) | |
| download | chrome-ec-41fe226267e3a8c1cb61f9f25123eaea900b4971.tar.gz | |
zork: Use CBI only and remove retimer probe code
Before CBI was being used, zork used I2C probing to
detect basic hardware configuration. Now that CBI
is supporting FW_CONFIG, this is being removed.
BUG=b:151232257
BRANCH=none
TEST=verify zork still boots with valid configuration
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: I267d99f8f3894aff2f6301df167c470db373509e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2304380
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Tested-by: Denis Brockus <dbrockus@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'baseboard/zork')
| -rw-r--r-- | baseboard/zork/cbi_ec_fw_config.c | 10 | ||||
| -rw-r--r-- | baseboard/zork/cbi_ec_fw_config.h | 3 |
2 files changed, 1 insertions, 12 deletions
diff --git a/baseboard/zork/cbi_ec_fw_config.c b/baseboard/zork/cbi_ec_fw_config.c index 1845fa1718..d8101855f7 100644 --- a/baseboard/zork/cbi_ec_fw_config.c +++ b/baseboard/zork/cbi_ec_fw_config.c @@ -10,17 +10,9 @@ /**************************************************************************** * CBI Zork EC FW Configuration */ -/* TODO(b:151232257) Remove probe code when hardware supports CBI */ -static uint32_t cached_fw_config = UNINITIALIZED_FW_CONFIG; -void set_cbi_fw_config(uint32_t val) -{ - cached_fw_config = val; -} - uint32_t get_cbi_fw_config(void) { - /* TODO(b:151232257) Remove probe code when hardware supports CBI */ - /* static uint32_t cached_fw_config = UNINITIALIZED_FW_CONFIG; */ + static uint32_t cached_fw_config = UNINITIALIZED_FW_CONFIG; if (cached_fw_config == UNINITIALIZED_FW_CONFIG) { uint32_t val; diff --git a/baseboard/zork/cbi_ec_fw_config.h b/baseboard/zork/cbi_ec_fw_config.h index 7b49464320..9222dd9f45 100644 --- a/baseboard/zork/cbi_ec_fw_config.h +++ b/baseboard/zork/cbi_ec_fw_config.h @@ -98,9 +98,6 @@ enum ec_cfg_lid_angle_tablet_mode_type { EC_CFG_LID_ANGLE_TABLET_MODE_L) -/* TODO(b:151232257) Remove probe code when hardware supports CBI */ -void set_cbi_fw_config(uint32_t val); - uint32_t get_cbi_fw_config(void); enum ec_cfg_usb_db_type ec_config_get_usb_db(void); enum ec_cfg_usb_mb_type ec_config_get_usb_mb(void); |