diff options
| author | Devin Lu <Devin.Lu@quantatw.com> | 2021-08-03 20:27:49 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-13 05:25:09 +0000 |
| commit | c425ace909b134095698dd604eb685cd2f620256 (patch) | |
| tree | b5e888f6b7a16e9acbbde5e89b595cc0a9580796 /baseboard/guybrush/baseboard.c | |
| parent | a388377c7699bcbca57bb495a0e55ea7543b394d (diff) | |
| download | chrome-ec-c425ace909b134095698dd604eb685cd2f620256.tar.gz | |
nct38xx: Split after-reset timestabilize-14151.B-main
Split after-reset time for NCT3807 and NCT3808, since the after-reset
time is not the same.
From the datasheet (section 4.4.2 Reset Timing) as following:
* | Min | Max |
* ----------------------+-------+-------+
* NCT3807 (single port) | x | 1.5ms |
* ----------------------+-------+-------+
* NCT3808 (dual port) | x | 3ms |
* ----------------------+-------+-------+
Currently the after-reset time for NCT3807 is zero. Change to 2ms to
fit specification as well.
BUG=none
BRANCH=none
TEST=On Redrix. Initial success with NCT3807.
TEST=On Dirinboz. Initial success with NCT3807.
TEST=make buildall.
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Change-Id: I1f47f57c0d8955946b1c2522e1a1736739217f41
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3068492
Reviewed-by: caveh jalali <caveh@chromium.org>
Diffstat (limited to 'baseboard/guybrush/baseboard.c')
| -rw-r--r-- | baseboard/guybrush/baseboard.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/baseboard/guybrush/baseboard.c b/baseboard/guybrush/baseboard.c index dcf56b1a78..4383598ff6 100644 --- a/baseboard/guybrush/baseboard.c +++ b/baseboard/guybrush/baseboard.c @@ -741,8 +741,8 @@ static void reset_nct38xx_port(int port) msleep(NCT38XX_RESET_HOLD_DELAY_MS); gpio_set_level(reset_gpio_l, 1); nct38xx_reset_notify(port); - if (NCT38XX_RESET_POST_DELAY_MS != 0) - msleep(NCT38XX_RESET_POST_DELAY_MS); + if (NCT3807_RESET_POST_DELAY_MS != 0) + msleep(NCT3807_RESET_POST_DELAY_MS); } |