diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2016-07-08 13:51:59 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-07-09 01:40:47 -0700 |
| commit | 815b1356903306c66b3a433f0daa4577e1182a2e (patch) | |
| tree | ae03d47f5266ccd34fe54ccc197a9a6330d753bd /Makefile | |
| parent | 9a13c52f30cd50a537b2ceeb2e5a62f398d458b6 (diff) | |
| download | chrome-ec-815b1356903306c66b3a433f0daa4577e1182a2e.tar.gz | |
Remove Makefile symlinks under board directory
This feature is inconsistent. Not all boards have such a symlink
(for a obvious reason).
This feature is fragile. It's most likely not tested and going to be
broken if not already. Developers won't like it if they have to test
two different ways to build boards before submitting patches.
This feature is not necessary. If you build EC in the standard way
(e.g. make BOARD=samus), these symlinks are not needed.
This feature is wasteful. Extra disk spaces are used and extra lines
are added to Makefile (increasing code complexity slightly).
BUG=chromium:626776
BRANCH=none
TEST=make buildall
Change-Id: Id5444284d773cb0e9225f39abd877441b8f61440
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/359321
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 18 |
1 files changed, 0 insertions, 18 deletions
@@ -5,23 +5,6 @@ # Embedded Controller firmware build system # -# If we came here via a symlink we restart make and deduce the correct BOARD -# value from the current directory. -SYMLINK := $(shell readlink $(lastword $(MAKEFILE_LIST))) - -ifneq (,$(SYMLINK)) - -.PHONY: restart -restart: .DEFAULT - @true - -.DEFAULT: - @$(MAKE) -C $(dir $(SYMLINK)) \ - --no-print-directory \ - $(MAKECMDGOALS) \ - BOARD=$(notdir $(shell pwd)) -else - BOARD ?= bds # Directory where the board is configured (includes /$(BOARD) at the end) @@ -209,4 +192,3 @@ libsharedobjs: $(libsharedobjs-y) include Makefile.rules export CROSS_COMPILE CFLAGS CC CPP LD NM AR OBJCOPY OBJDUMP -endif # SYMLINK |