diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-10-31 09:50:42 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-10-31 21:57:29 +0000 |
| commit | ea188ffdb7dd75e3bfc50c248436bd29388b90e1 (patch) | |
| tree | 41cd49c046a4f8eaf286c8e2764ee224d033f5d6 | |
| parent | af8d3f9536010072c673dbf447bd08742628a222 (diff) | |
| download | chrome-ec-ea188ffdb7dd75e3bfc50c248436bd29388b90e1.tar.gz | |
cleanup: TODOs in ec_commands.h
Comment changes only; no code changes.
BUG=chrome-os-partner:11223
BRANCH=none
TEST=build all boards; pass unit tests
Change-Id: I8f6f57514886dd1fda0e44cae1b036c22be481f8
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/175228
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
| -rw-r--r-- | common/host_command.c | 1 | ||||
| -rw-r--r-- | include/ec_commands.h | 13 |
2 files changed, 10 insertions, 4 deletions
diff --git a/common/host_command.c b/common/host_command.c index 34c274001a..a0d703b90a 100644 --- a/common/host_command.c +++ b/common/host_command.c @@ -372,6 +372,7 @@ void host_command_task(void) /*****************************************************************************/ /* Host commands */ +/* TODO(crosbug.com/p/11223): Remove this once the kernel no longer cares */ static int host_command_proto_version(struct host_cmd_handler_args *args) { struct ec_response_proto_version *r = args->response; diff --git a/include/ec_commands.h b/include/ec_commands.h index 9af502ca9a..4ed4890f0b 100644 --- a/include/ec_commands.h +++ b/include/ec_commands.h @@ -8,8 +8,13 @@ #ifndef __CROS_EC_COMMANDS_H #define __CROS_EC_COMMANDS_H -/* Current version of this protocol */ -/* TODO: This is effectively useless; protocol is determined in other ways */ +/* + * Current version of this protocol + * + * TODO(crosbug.com/p/11223): This is effectively useless; protocol is + * determined in other ways. Remove this once the kernel code no longer + * depends on it. + */ #define EC_PROTO_VERSION 0x00000002 /* Command version mask */ @@ -1764,8 +1769,8 @@ struct ec_params_sb_wr_block { /* System commands */ /* - * TODO: this is a confusing name, since it doesn't necessarily reboot the EC. - * Rename to "set image" or something similar. + * TODO(crosbug.com/p/23747): This is a confusing name, since it doesn't + * necessarily reboot the EC. Rename to "image" or something similar? */ #define EC_CMD_REBOOT_EC 0xd2 |