diff options
| author | Mary Ruthven <mruthven@chromium.org> | 2019-10-30 18:22:37 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-11-07 22:52:12 +0000 |
| commit | c3126e7f49743606d1686163b446af3a4db15965 (patch) | |
| tree | 0a9e0cdd022ce1737f045910a4ce4d194dd59d61 | |
| parent | e347d4a090d8963773ccf221b270afea21f9dc73 (diff) | |
| download | chrome-ec-c3126e7f49743606d1686163b446af3a4db15965.tar.gz | |
g: bid: show type is empty instead of an error
It's ok if type and type_inv are both empty. Only show an error if the
board ID type isn't empty and the inversion is incorrect.
BUG=none
BRANCH=cr50
TEST=set whitelabel rlz and run 'bid' command. Make sure the warning
isn't shown.
Change-Id: I12b1e4b34559bc8b6ad482d9694c9dd143bfcd1c
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1892121
Reviewed-by: Namyoon Woo <namyoon@chromium.org>
| -rw-r--r-- | chip/g/board_id.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/g/board_id.c b/chip/g/board_id.c index d97ba31870..1c9fe81afb 100644 --- a/chip/g/board_id.c +++ b/chip/g/board_id.c @@ -225,7 +225,7 @@ static int command_board_id(int argc, char **argv) if (board_id_is_blank(&id)) return rv; /* The space is not initialized. */ - if (id.type != ~id.type_inv) + if (!board_id_type_is_blank(&id) && id.type != ~id.type_inv) ccprintf("Inv Type Mismatch (%08x instead of %08x)!\n", id.type_inv, ~id.type); } |