diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2018-08-20 08:28:04 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2018-08-31 05:03:21 +0000 |
| commit | 4de879a6619a3fb5338a9e229e7193278ecfd1f7 (patch) | |
| tree | bf1d4d500fbc36b63b0807479d35bbf5c2a77e75 | |
| parent | 4b490cbb31aa9cb817864cf525fce21bf2943c41 (diff) | |
| download | chrome-ec-4de879a6619a3fb5338a9e229e7193278ecfd1f7.tar.gz | |
ectool: Fix ADC read return value.
This commit fixes a bug with the ectool adcread command. For successful
reads, it was returning a non-zero return code.
BUG=b:76155036
BRANCH=None
TEST=Use `ectool adcread` on non-existent ADC channel, verify return
code is non-zero. Use it on a valid channel, verify the return code is
0.
Change-Id: Ida8208bf100a3d66bd132770fb352678f408560c
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1181173
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
(cherry picked from commit b059ccdead89713485fc031faa622115d0839d57)
Reviewed-on: https://chromium-review.googlesource.com/1183861
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
(cherry picked from commit 06cfd8cfb3b0dfb838c0e5d09fa22d49ef39966c)
Reviewed-on: https://chromium-review.googlesource.com/1198349
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>
| -rw-r--r-- | util/ectool.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/ectool.c b/util/ectool.c index e6332373c3..c2ce4dc8da 100644 --- a/util/ectool.c +++ b/util/ectool.c @@ -405,8 +405,10 @@ int cmd_adc_read(int argc, char *argv[]) } rv = ec_command(EC_CMD_ADC_READ, 0, &p, sizeof(p), &r, sizeof(r)); - if (rv > 0) + if (rv > 0) { printf("%s: %d\n", argv[1], r.adc_value); + return 0; + } return rv; } |