diff options
| author | Cloud_Lin <cloud_lin@compal.com> | 2017-04-06 16:39:25 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-04-11 20:22:36 -0700 |
| commit | 1b98fcdcf067cb0055f119d56484887b7cfd7520 (patch) | |
| tree | feba477bf3c5892ffb31da5517eb5d6634fb9d6e | |
| parent | dda95414481661799d65b3f1de99156df22c4907 (diff) | |
| download | chrome-ec-1b98fcdcf067cb0055f119d56484887b7cfd7520.tar.gz | |
kahlee: Modify PD port2 I2C address and clean up unused function
1. PD vender suggests to use chip default address setting (0x16).
2. Clean up board_print_tcpc_fw version function and related define.
BRANCH=None
BUG=None
TEST=Plug in type-c device and check behavior
Change-Id: I44b7156c914b8de67630696e4534147cc3b7f2c3
Reviewed-on: https://chromium-review.googlesource.com/469449
Commit-Ready: Lin Cloud <cloud_lin@compal.com>
Tested-by: Lin Cloud <cloud_lin@compal.com>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
| -rw-r--r-- | board/kahlee/board.c | 16 | ||||
| -rw-r--r-- | board/kahlee/board.h | 3 | ||||
| -rw-r--r-- | include/config.h | 3 |
3 files changed, 1 insertions, 21 deletions
diff --git a/board/kahlee/board.c b/board/kahlee/board.c index 242c6fa1d7..8672e96643 100644 --- a/board/kahlee/board.c +++ b/board/kahlee/board.c @@ -178,7 +178,7 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_COUNT] = { }, [1] = { .i2c_host_port = NPCX_I2C_PORT0_1, - .i2c_slave_addr = 0x36, + .i2c_slave_addr = 0x16, .drv = &tcpci_tcpm_drv, .pol = TCPC_ALERT_ACTIVE_LOW, }, @@ -245,20 +245,6 @@ void board_reset_pd_mcu(void) gpio_set_level(GPIO_USB_C0_PD_RST_ODL, 1); } -#ifdef CONFIG_USB_PD_TCPC_FW_VERSION -void board_print_tcpc_fw_version(int port) -{ - int rv; - int version; - - if (port >= 0) - rv = ps8751_tcpc_get_fw_version(port, &version); - - if (!rv) - CPRINTS("TCPC p%d FW VER: 0x%x", port, version); -} -#endif - void board_tcpc_init(void) { int port, reg, reg2; diff --git a/board/kahlee/board.h b/board/kahlee/board.h index 7c8b790899..8e76d2c4c0 100644 --- a/board/kahlee/board.h +++ b/board/kahlee/board.h @@ -74,7 +74,6 @@ #undef CONFIG_USB_PD_VBUS_DETECT_CHARGER #define ADC_VBUS -1 #define CONFIG_USB_PD_TCPC_LOW_POWER -#define CONFIG_USB_PD_TCPC_FW_VERSION #define CONFIG_USB_PD_TCPM_MUX #define CONFIG_USB_PD_TCPM_PS8751 #define CONFIG_USB_PD_TCPM_TCPCI @@ -292,8 +291,6 @@ void board_reset_pd_mcu(void); int board_get_version(void); -void board_print_tcpc_fw_version(int port); - #endif /* !__ASSEMBLER__ */ #endif /* __CROS_EC_BOARD_H */ diff --git a/include/config.h b/include/config.h index b94fef6eeb..b65b24f21b 100644 --- a/include/config.h +++ b/include/config.h @@ -2395,9 +2395,6 @@ /* USB Device version of product */ #undef CONFIG_USB_BCD_DEV -/* Support TCPC FW version */ -#undef CONFIG_USB_PD_TCPC_FW_VERSION - /*****************************************************************************/ /* Compile chip support for the USB device controller */ |