summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@google.com>2017-01-19 12:07:16 +0800
committerchrome-bot <chrome-bot@chromium.org>2017-01-19 06:11:50 -0800
commit3baf37633e4e80f356d92ee5da0ddc0a0b463849 (patch)
tree1d932251c97aa56da82b69d8efb95b8e9dd742cb
parent056429f1210dba694e138555e28385af46127679 (diff)
downloadchrome-ec-3baf37633e4e80f356d92ee5da0ddc0a0b463849.tar.gz
poppy: Fix USB_C[0|1]_CHARGE_L default GPIO setting
Leave the GPIO as low, without pull-up, so that system can boot without battery. Also remove uneeded pull-up on USBC[0|1]_5V_EN. BRANCH=none BUG=chrome-os-partner:61998 TEST=Boot poppy without battery Change-Id: Ib7a334d5e4ecf1ea434354b3b161111cf005418c Reviewed-on: https://chromium-review.googlesource.com/430530 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org>
-rw-r--r--board/poppy/gpio.inc8
1 files changed, 4 insertions, 4 deletions
diff --git a/board/poppy/gpio.inc b/board/poppy/gpio.inc
index 4791af4e9c..7638e1e8d1 100644
--- a/board/poppy/gpio.inc
+++ b/board/poppy/gpio.inc
@@ -84,10 +84,10 @@ GPIO(I2C3_SCL, PIN(D, 1), GPIO_INPUT) /* EC_I2C3_SENSOR_1V8_SCL */
GPIO(I2C3_SDA, PIN(D, 0), GPIO_INPUT) /* EC_I2C3_SENSOR_1V8_SDA */
/* 5V enables: INPUT=1.5A, OUT_LOW=OFF, OUT_HIGH=3A */
-GPIO(USB_C0_5V_EN, PIN(4, 2), GPIO_OUT_LOW | GPIO_PULL_UP) /* C0 5V Enable */
-GPIO(USB_C0_CHARGE_L, PIN(C, 0), GPIO_OUT_LOW | GPIO_PULL_UP) /* C0 Charge enable */
-GPIO(USB_C1_5V_EN, PIN(B, 1), GPIO_OUT_LOW | GPIO_PULL_UP) /* C1 5V Enable */
-GPIO(USB_C1_CHARGE_L, PIN(C, 3), GPIO_OUT_LOW | GPIO_PULL_UP) /* C0 Charge enable */
+GPIO(USB_C0_5V_EN, PIN(4, 2), GPIO_OUT_LOW) /* C0 5V Enable */
+GPIO(USB_C0_CHARGE_L, PIN(C, 0), GPIO_OUT_LOW) /* C0 Charge enable */
+GPIO(USB_C1_5V_EN, PIN(B, 1), GPIO_OUT_LOW) /* C1 5V Enable */
+GPIO(USB_C1_CHARGE_L, PIN(C, 3), GPIO_OUT_LOW) /* C1 Charge enable */
GPIO(USB_C0_CABLE_DET, PIN(D, 2), GPIO_INPUT) /* C0 Cable Detect */
GPIO(USB_C0_PD_RST_L, PIN(0, 3), GPIO_OUT_LOW) /* C0 PD Reset */
GPIO(USB_C1_PD_RST_L, PIN(7, 4), GPIO_OUT_LOW) /* C1 PD Reset */