diff options
| author | Martin Roth <martinroth@chromium.org> | 2016-08-12 11:27:30 -0600 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-08-23 15:36:52 -0700 |
| commit | 6e866962a0ed5ffa7af96555e2855e4046e5ab7f (patch) | |
| tree | 2d38840107517b2dd6dcb23e3102d65f9f3c326b | |
| parent | 866add68ed07458fb413f3d1a664139654c2768f (diff) | |
| download | chrome-ec-6e866962a0ed5ffa7af96555e2855e4046e5ab7f.tar.gz | |
charger/bd99955: only print data if read was successful
In console_command_bd99955(), because the return value wasn't being
checked before displaying the data variable, it could be printed without
being initialized.
TEST=Build
BUG=None
BRANCH=None
Change-Id: I03e0aae6fee33e32f648d952d6f2906e71f67ea2
Signed-off-by: Martin Roth <martinroth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/371398
Reviewed-by: David Hendricks <dhendrix@chromium.org>
| -rw-r--r-- | driver/charger/bd99955.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/driver/charger/bd99955.c b/driver/charger/bd99955.c index 43a6bc4bcb..4aa4311cfb 100644 --- a/driver/charger/bd99955.c +++ b/driver/charger/bd99955.c @@ -994,7 +994,8 @@ static int console_command_bd99955(int argc, char **argv) rv = ch_raw_read16(reg, &data, cmd); } - CPRINTS("register 0x%x [%d] = 0x%x [%d]", reg, reg, data, data); + if (rv == EC_SUCCESS) + CPRINTS("register 0x%x [%d] = 0x%x [%d]", reg, reg, data, data); return rv; } |