diff options
| author | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2016-02-01 10:08:33 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-02-01 17:18:23 -0800 |
| commit | 4f6f505900a0b8c2e16955b5eb69a9213fc6076d (patch) | |
| tree | 87e2b89ef69efdf4efeb94b017fe44faf25fdffa | |
| parent | c8484a91380bc7c4441cdeffac7ede5c387e5d09 (diff) | |
| download | chrome-ec-4f6f505900a0b8c2e16955b5eb69a9213fc6076d.tar.gz | |
Fix null pointer check in tokenFilename()
From https://scan.coverity.com/projects/chromium-ec :
CID61407: Dereference after null check
The home directory that is received from getpwuid()
needs to be assigned to home but it wasn't.
BUG=none
BRANCH=none
TEST=build tested
Signed-off-by: Stefan Reinauer <reinauer@chromium.org>
Change-Id: I36c30906e1388e2f8a0d466d516a5ffa6ae70bf6
Reviewed-on: https://chromium-review.googlesource.com/324637
Commit-Ready: Stefan Reinauer <reinauer@chromium.org>
Tested-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
| -rw-r--r-- | util/signer/gnubby.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/util/signer/gnubby.cc b/util/signer/gnubby.cc index a1fa158a22..549daa319c 100644 --- a/util/signer/gnubby.cc +++ b/util/signer/gnubby.cc @@ -294,7 +294,8 @@ void getPIN(uint8_t* out) { static std::string tokenFilename(const uint8_t* fp) { const char* home = getenv("HOME"); - if (home == NULL) getpwuid(getuid())->pw_dir; + if (home == NULL) + home = getpwuid(getuid())->pw_dir; std::string s(home); s.append("/.tmp/"); for (int i = 0; i < 32; ++i) { |