diff options
| author | Vic Yang <victoryang@google.com> | 2015-02-09 14:59:33 -0800 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-02-10 06:47:44 +0000 |
| commit | 9ed4434ad8770ca3edd6bccd456738019c9e08b0 (patch) | |
| tree | 94889883fda63680474d0bf841b336d1e9e40e15 | |
| parent | d73e8cb9c9d1eea0ce0e0336ff13cd9e67584bce (diff) | |
| download | chrome-ec-9ed4434ad8770ca3edd6bccd456738019c9e08b0.tar.gz | |
mec1322: Fix LPC interrupt bit mask
LRESET# interrupt should be GIRQ19 bit 0 instead of bit 1.
BRANCH=None
BUG=chrome-os-partner:36326
TEST=Run on Glower and doesn't see LRESET# interrupt storm.
Change-Id: I1adedea63e9ec2851e1e09fc8c0eb8185070dad1
Signed-off-by: Vic Yang <victoryang@google.com>
Reviewed-on: https://chromium-review.googlesource.com/247790
Tested-by: Vic Yang <victoryang@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Commit-Queue: Vic Yang <victoryang@chromium.org>
| -rw-r--r-- | chip/mec1322/lpc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chip/mec1322/lpc.c b/chip/mec1322/lpc.c index 07e75f2a09..ba7e83a9ba 100644 --- a/chip/mec1322/lpc.c +++ b/chip/mec1322/lpc.c @@ -193,8 +193,8 @@ static void setup_lpc(void) gpio_config_module(MODULE_LPC, 1); /* Set up interrupt on LRESET# deassert */ - MEC1322_INT_SOURCE(19) |= 1 << 1; - MEC1322_INT_ENABLE(19) |= 1 << 1; + MEC1322_INT_SOURCE(19) |= 1 << 0; + MEC1322_INT_ENABLE(19) |= 1 << 0; MEC1322_INT_BLK_EN |= 1 << 19; task_enable_irq(MEC1322_IRQ_GIRQ19); @@ -257,7 +257,7 @@ DECLARE_HOOK(HOOK_INIT, lpc_init, HOOK_PRIO_INIT_LPC); void girq19_interrupt(void) { /* Check interrupt result for LRESET# trigger */ - if (MEC1322_INT_RESULT(19) & (1 << 1)) { + if (MEC1322_INT_RESULT(19) & (1 << 0)) { /* Initialize LPC module when LRESET# is deasserted */ if (!lpc_get_pltrst_asserted()) { setup_lpc(); @@ -270,7 +270,7 @@ void girq19_interrupt(void) lpc_get_pltrst_asserted() ? "" : "de"); /* Clear interrupt source */ - MEC1322_INT_SOURCE(19) |= 1 << 1; + MEC1322_INT_SOURCE(19) |= 1 << 0; } } DECLARE_IRQ(MEC1322_IRQ_GIRQ19, girq19_interrupt, 1); |